Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add create and delete model #462

Merged
merged 3 commits into from Jun 18, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jun 18, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested a review from stephaniewang526 Jun 18, 2020
@googlebot googlebot added the cla: yes label Jun 18, 2020
@pmakani pmakani added the kokoro:force-run label Jun 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 18, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 18, 2020

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #462   +/-   ##
=========================================
  Coverage     81.36%   81.36%           
  Complexity     1225     1225           
=========================================
  Files            77       77           
  Lines          6218     6218           
  Branches        691      691           
=========================================
  Hits           5059     5059           
  Misses          802      802           
  Partials        357      357           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68140d5...101c4db. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit df6479f into googleapis:master Jun 18, 2020
15 checks passed
@pmakani pmakani deleted the create-delete-model branch Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants