Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle malformed backend responses for PolicyTag messages #522

Merged
merged 1 commit into from Jul 10, 2020

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 9, 2020

When you delete a policy tag from a column in BigQuery, rather than
eliding the policyTag message entirely, it will return an empty
message (with no names field). This change treats such responses
as equivalent to no PolicyTag message being present.

reported as internal issue: 160857208

When you delete a policy tag from a column in BigQuery, rather than
eliding the policyTag message entirely, it will return an empty
message (with no name field).  This change treats such responses
as equivalent to no PolicyTag message being present.
@googlebot googlebot added the cla: yes label Jul 9, 2020
@shollyman shollyman changed the title fix: handle malformed backend responses for PolicyTag messages. fix: handle malformed backend responses for PolicyTag messages Jul 9, 2020
@shollyman shollyman requested a review from stephaniewang526 Jul 9, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 9, 2020

Codecov Report

Merging #522 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #522   +/-   ##
=========================================
  Coverage     81.48%   81.49%           
- Complexity     1225     1226    +1     
=========================================
  Files            77       77           
  Lines          6218     6220    +2     
  Branches        691      690    -1     
=========================================
+ Hits           5067     5069    +2     
  Misses          792      792           
  Partials        359      359           
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/bigquery/PolicyTags.java 100.00% <100.00%> (ø) 6.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77e74e...562d608. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 64de23a into googleapis:master Jul 10, 2020
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants