Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add table exists #610

Merged
merged 1 commit into from Jul 28, 2020
Merged

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 28, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and Jul 28, 2020
@google-cla google-cla bot added the cla: yes label Jul 28, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 28, 2020

Codecov Report

Merging #610 into master will decrease coverage by 1.20%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #610      +/-   ##
============================================
- Coverage     82.63%   81.43%   -1.21%     
- Complexity     1224     1226       +2     
============================================
  Files            77       77              
  Lines          5102     6210    +1108     
  Branches        565      681     +116     
============================================
+ Hits           4216     5057     +841     
- Misses          595      790     +195     
- Partials        291      363      +72     
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/GoogleSheetsOptions.java 77.14% <0.00%> (-12.86%) 10.00% <0.00%> (ø%)
...main/java/com/google/cloud/bigquery/ModelInfo.java 78.48% <0.00%> (-9.12%) 25.00% <0.00%> (ø%)
...google/cloud/bigquery/HivePartitioningOptions.java 83.78% <0.00%> (-6.22%) 11.00% <0.00%> (ø%)
...main/java/com/google/cloud/bigquery/DatasetId.java 81.25% <0.00%> (-5.42%) 13.00% <0.00%> (ø%)
.../com/google/cloud/bigquery/ConnectionProperty.java 91.89% <0.00%> (-5.26%) 12.00% <0.00%> (ø%)
.../google/cloud/bigquery/DatastoreBackupOptions.java 88.23% <0.00%> (-5.10%) 8.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/InsertAllRequest.java 86.25% <0.00%> (-3.75%) 23.00% <0.00%> (ø%)
...in/java/com/google/cloud/bigquery/TableResult.java 85.29% <0.00%> (-3.60%) 15.00% <0.00%> (ø%)
.../java/com/google/cloud/bigquery/FormatOptions.java 44.44% <0.00%> (-3.56%) 12.00% <0.00%> (ø%)
...google/cloud/bigquery/ExternalTableDefinition.java 58.09% <0.00%> (-3.37%) 19.00% <0.00%> (ø%)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6a874...d631ec1. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit db9eef7 into googleapis:master Jul 28, 2020
15 of 16 checks passed
@pmakani pmakani deleted the table-exists branch Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants