Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add query with positional type parameters #634

Merged

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Aug 3, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and Aug 3, 2020
@google-cla google-cla bot added the cla: yes label Aug 3, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 3, 2020

Codecov Report

Merging #634 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #634      +/-   ##
============================================
- Coverage     81.49%   81.45%   -0.05%     
+ Complexity     1226     1225       -1     
============================================
  Files            77       77              
  Lines          6220     6200      -20     
  Branches        691      677      -14     
============================================
- Hits           5069     5050      -19     
+ Misses          792      791       -1     
  Partials        359      359              
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0.00%> (-1.32%) 7.00% <0.00%> (ø%)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0.00%> (-1.10%) 5.00% <0.00%> (ø%)
...gle/cloud/bigquery/MaterializedViewDefinition.java 70.00% <0.00%> (-0.97%) 6.00% <0.00%> (ø%)
...ava/com/google/cloud/bigquery/RoutineArgument.java 90.47% <0.00%> (-0.44%) 5.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/StandardSQLField.java 90.47% <0.00%> (-0.44%) 7.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/ViewDefinition.java 87.09% <0.00%> (-0.41%) 11.00% <0.00%> (ø%)
...google/cloud/bigquery/ExternalTableDefinition.java 57.69% <0.00%> (-0.41%) 19.00% <0.00%> (ø%)
...y/src/main/java/com/google/cloud/bigquery/Job.java 86.13% <0.00%> (-0.20%) 31.00% <0.00%> (-1.00%)
...om/google/cloud/bigquery/BigtableColumnFamily.java 95.83% <0.00%> (-0.17%) 5.00% <0.00%> (ø%)
...google/cloud/bigquery/StandardTableDefinition.java 93.24% <0.00%> (-0.10%) 16.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108e462...5e6e4fe. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 208883c into googleapis:master Aug 3, 2020
15 of 16 checks passed
@pmakani pmakani deleted the query-params-positional-types branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants