Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update samples README.md #667

Merged
merged 3 commits into from Aug 12, 2020
Merged

docs: update samples README.md #667

merged 3 commits into from Aug 12, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Aug 10, 2020

No description provided.

@stephaniewang526 stephaniewang526 requested a review from Aug 10, 2020
@google-cla google-cla bot added the cla: yes label Aug 10, 2020
@stephaniewang526 stephaniewang526 requested a review from pmakani Aug 10, 2020
@stephaniewang526 stephaniewang526 added the automerge label Aug 10, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 10, 2020

Codecov Report

Merging #667 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #667   +/-   ##
=========================================
  Coverage     81.49%   81.49%           
  Complexity     1226     1226           
=========================================
  Files            77       77           
  Lines          6220     6220           
  Branches        691      690    -1     
=========================================
  Hits           5069     5069           
  Misses          792      792           
  Partials        359      359           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc44df...0bbb1c8. Read the comment docs.

samples/README.md Outdated Show resolved Hide resolved
samples/README.md Outdated Show resolved Hide resolved
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Aug 10, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@stephaniewang526 stephaniewang526 removed the automerge label Aug 10, 2020
@stephaniewang526 stephaniewang526 changed the title docs: update samples README.md and refactor SimpleQuery docs: update samples README.md Aug 11, 2020
@stephaniewang526 stephaniewang526 requested a review from lesv Aug 11, 2020
lesv
lesv approved these changes Aug 12, 2020
Copy link

@lesv lesv left a comment

This still isn't the right way to execute this sample.

@stephaniewang526 stephaniewang526 merged commit 60d904b into master Aug 12, 2020
16 checks passed
@stephaniewang526 stephaniewang526 deleted the samples-readme branch Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants