Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional time partitioning intervals #737

Merged

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Sep 16, 2020

No description provided.

@stephaniewang526 stephaniewang526 requested a review from shollyman Sep 16, 2020
@google-cla google-cla bot added the cla: yes label Sep 16, 2020
@stephaniewang526 stephaniewang526 requested a review from pmakani Sep 16, 2020
@stephaniewang526 stephaniewang526 added the do not merge label Sep 16, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 16, 2020

Codecov Report

Merging #737 into master will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #737      +/-   ##
============================================
- Coverage     81.07%   80.62%   -0.45%     
- Complexity     1236     1240       +4     
============================================
  Files            78       78              
  Lines          6334     6385      +51     
  Branches        704      708       +4     
============================================
+ Hits           5135     5148      +13     
- Misses          833      870      +37     
- Partials        366      367       +1     
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/bigquery/TimePartitioning.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 4.43% <0.00%> (-0.52%) 2.00% <0.00%> (ø%)
...y/src/main/java/com/google/cloud/bigquery/Job.java 85.90% <0.00%> (-0.01%) 34.00% <0.00%> (+2.00%) ⬇️
...n/java/com/google/cloud/bigquery/JobException.java 83.33% <0.00%> (+83.33%) 2.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061c148...b8dfa37. Read the comment docs.

Copy link
Contributor

@shollyman shollyman left a comment

minor docstring updates

@product-auto-label product-auto-label bot added the api: bigquery label Sep 17, 2020
@stephaniewang526 stephaniewang526 requested a review from as a code owner Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants