Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add query external bigtable using permanent table #764

Merged

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Sep 30, 2020

No description provided.

@pmakani pmakani requested a review from stephaniewang526 Sep 30, 2020
@google-cla google-cla bot added the cla: yes label Sep 30, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Sep 30, 2020
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Sep 30, 2020

Hi @billyjacobson -- PTAL as well! Thank you.

@stephaniewang526 stephaniewang526 marked this pull request as ready for review Sep 30, 2020
@stephaniewang526 stephaniewang526 requested a review from Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 30, 2020
@pmakani pmakani added the kokoro:force-run label Sep 30, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 30, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 30, 2020

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #764   +/-   ##
=========================================
  Coverage     80.41%   80.41%           
  Complexity     1265     1265           
=========================================
  Files            79       79           
  Lines          6530     6530           
  Branches        742      743    +1     
=========================================
  Hits           5251     5251           
  Misses          889      889           
  Partials        390      390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 038e55d...4905230. Read the comment docs.

lesv
lesv approved these changes Sep 30, 2020
Copy link

@lesv lesv left a comment

LGTM for java-samples

// once, and can be reused for multiple requests.
BigQuery bigquery = BigQueryOptions.getDefaultInstance().getService();

BigtableColumn name =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments from #763 regarding example bigtable schema

Copy link
Contributor Author

@pmakani pmakani Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@product-auto-label product-auto-label bot added api: bigquery samples labels Oct 1, 2020
@pmakani pmakani force-pushed the query-external-bigtable-perm branch from d2cc43b to 4905230 Compare Oct 7, 2020
@pmakani
Copy link
Contributor Author

@pmakani pmakani commented Oct 7, 2020

@stephaniewang526 stephaniewang526 merged commit 257edfc into googleapis:master Oct 7, 2020
18 checks passed
@pmakani pmakani deleted the query-external-bigtable-perm branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants