Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update clustering field docstrings #774



Copy link

@ryanyuan ryanyuan commented Sep 30, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #773 ☕️

@ryanyuan ryanyuan requested a review from as a code owner Sep 30, 2020
@ryanyuan ryanyuan requested a review from Sep 30, 2020
@google-cla google-cla bot added the cla: yes label Sep 30, 2020
Copy link

@codecov codecov bot commented Sep 30, 2020

Codecov Report

Merging #774 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #774   +/-   ##
  Coverage     80.40%   80.40%           
  Complexity     1263     1263           
  Files            79       79           
  Lines          6517     6517           
  Branches        740      740           
  Hits           5240     5240           
  Misses          888      888           
  Partials        389      389           
Impacted Files Coverage Δ Complexity Δ 93.33% <ø> (ø) 16.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647a7d4...bff3c61. Read the comment docs.

lesv approved these changes Oct 1, 2020
@pmakani pmakani added the kokoro:force-run label Oct 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 1, 2020
pmakani approved these changes Oct 1, 2020
@pmakani pmakani merged commit 58e2e4e into googleapis:master Oct 1, 2020
18 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 1, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [1.121.0]( (2020-10-01)

### Features

* add case insensitive for fields get by name ([#775]( ([fcea662](
* use bigquery exception ([#749]( ([84d6632](

### Bug Fixes

* nullpointer exception when executionerror is null ([#754]( ([03bda1b](

### Dependencies

* update dependency to v2-rev20200916-1.30.10 ([#768]( ([6f8911a](
* update dependency to v0.10.0 ([#769]( ([49dbbba](
* update dependency to v1.113.1 ([#770]( ([34f30ec](

### Documentation

* update clustering field docstrings ([#774]( ([58e2e4e](
* **samples:** add region tag for auth snippet ([#760]( ([9709c9e](
* **samples:** fix flaky test case for undelete table ([#757]( ([85b7069](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

4 participants