Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connectionId support for external data sources #776

Merged
merged 4 commits into from Oct 1, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Oct 1, 2020

Add connecitonId to ExternalTableDefinition to allow external data source query through the BigQuery client.

@stephaniewang526 stephaniewang526 requested a review from as a code owner Oct 1, 2020
@google-cla google-cla bot added the cla: yes label Oct 1, 2020
@stephaniewang526 stephaniewang526 requested a review from pmakani Oct 1, 2020
@stephaniewang526 stephaniewang526 requested a review from as a code owner Oct 1, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 1, 2020

Codecov Report

Merging #776 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #776      +/-   ##
============================================
- Coverage     80.41%   80.39%   -0.02%     
- Complexity     1263     1265       +2     
============================================
  Files            79       79              
  Lines          6519     6525       +6     
  Branches        739      743       +4     
============================================
+ Hits           5242     5246       +4     
- Misses          888      889       +1     
- Partials        389      390       +1     
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/ExternalTableDefinition.java 58.55% <66.66%> (+0.46%) 21.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce695f...68f13c7. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigquery label Oct 1, 2020
@stephaniewang526 stephaniewang526 requested a review from shollyman Oct 1, 2020
@stephaniewang526 stephaniewang526 added the automerge label Oct 1, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit dcd7daa into googleapis:master Oct 1, 2020
14 of 16 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 1, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.122.0](https://www.github.com/googleapis/java-bigquery/compare/v1.121.0...v1.122.0) (2020-10-01)


### Features

* add connectionId support for external data sources ([#776](https://www.github.com/googleapis/java-bigquery/issues/776)) ([dcd7daa](https://www.github.com/googleapis/java-bigquery/commit/dcd7daa15d8f820affc9c155ba6d7a9a4c15066d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants