Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema and totalRows for duplicate request ids #804

Merged
merged 3 commits into from Oct 19, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Oct 15, 2020

Fixes #802

@pmakani pmakani requested a review from stephaniewang526 Oct 15, 2020
@pmakani pmakani requested a review from as a code owner Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 15, 2020

Codecov Report

Merging #804 into master will decrease coverage by 0.04%.
The diff coverage is 45.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #804      +/-   ##
============================================
- Coverage     80.42%   80.37%   -0.05%     
- Complexity     1266     1268       +2     
============================================
  Files            79       79              
  Lines          6534     6548      +14     
  Branches        747      749       +2     
============================================
+ Hits           5255     5263       +8     
- Misses          888      892       +4     
- Partials        391      393       +2     
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 82.37% <45.45%> (-0.67%) 85.00 <0.00> (ø)
...google/cloud/bigquery/HivePartitioningOptions.java 85.41% <0.00%> (+1.63%) 13.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2fa96a...3982ea5. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigquery label Oct 16, 2020
@stephaniewang526 stephaniewang526 merged commit f2799dd into googleapis:master Oct 19, 2020
18 of 20 checks passed
@pmakani pmakani deleted the bigquery-802 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants