Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support authorized UDF entries in dataset ACL #875

Merged
merged 1 commit into from Oct 27, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Oct 27, 2020

No description provided.

@pmakani pmakani requested a review from as a code owner Oct 27, 2020
@google-cla google-cla bot added the cla: yes label Oct 27, 2020
@codecov
Copy link

@codecov codecov bot commented Oct 27, 2020

Codecov Report

Merging #875 into master will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #875      +/-   ##
============================================
- Coverage     80.38%   80.38%   -0.01%     
- Complexity     1268     1270       +2     
============================================
  Files            79       79              
  Lines          6547     6570      +23     
  Branches        749      756       +7     
============================================
+ Hits           5263     5281      +18     
- Misses          891      893       +2     
- Partials        393      396       +3     
Impacted Files Coverage Δ Complexity Δ
...y/src/main/java/com/google/cloud/bigquery/Acl.java 72.00% <72.22%> (+0.57%) 14.00 <1.00> (+1.00)
...in/java/com/google/cloud/bigquery/DatasetInfo.java 95.55% <83.33%> (-0.43%) 36.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6fd55...e957521. Read the comment docs.

Copy link
Contributor

@shollyman shollyman left a comment

Changes themselves look good, but let's update the description for this change to describe things a bit better. Perhaps "feat: support authorized UDF entries in dataset ACL" or similar.

@stephaniewang526 stephaniewang526 changed the title feat: add acl for routine feat: support authorized UDF entries in dataset ACL Oct 27, 2020
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Oct 27, 2020

okay -- thank you @shollyman!

@stephaniewang526 stephaniewang526 merged commit b031447 into googleapis:master Oct 27, 2020
18 of 20 checks passed
@pmakani pmakani deleted the authorize-routines branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants