Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure to fall back to old query path when query job is incomplete #941

Merged
merged 5 commits into from Nov 13, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Nov 12, 2020

When the query job takes more than 10s we must fall back to the old query path!

cc @epavan

@stephaniewang526 stephaniewang526 requested a review from as a code owner Nov 12, 2020
@stephaniewang526 stephaniewang526 requested a review from shollyman Nov 12, 2020
@google-cla google-cla bot added the cla: yes label Nov 12, 2020
@product-auto-label product-auto-label bot added the api: bigquery label Nov 12, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 12, 2020

Codecov Report

Merging #941 (5aa0f7f) into master (22e8bd7) will increase coverage by 0.07%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #941      +/-   ##
============================================
+ Coverage     80.33%   80.40%   +0.07%     
- Complexity     1270     1271       +1     
============================================
  Files            79       79              
  Lines          6574     6573       -1     
  Branches        759      759              
============================================
+ Hits           5281     5285       +4     
+ Misses          897      893       -4     
+ Partials        396      395       -1     
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 83.08% <80.00%> (+0.71%) 86.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e8bd7...5aa0f7f. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit bd7d85c into googleapis:master Nov 13, 2020
19 of 20 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 13, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.124.6](https://www.github.com/googleapis/java-bigquery/compare/v1.124.5...v1.124.6) (2020-11-13)


### Bug Fixes

* make sure to fall back to old query path when query job is incomplete ([#941](https://www.github.com/googleapis/java-bigquery/issues/941)) ([bd7d85c](https://www.github.com/googleapis/java-bigquery/commit/bd7d85c489cd260feeabbdc9ecbb8dcdc8d9ae77))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigtable to v1.17.3 ([#936](https://www.github.com/googleapis/java-bigquery/issues/936)) ([0b34a50](https://www.github.com/googleapis/java-bigquery/commit/0b34a5095b2bad4ac02b3d40937dd1a3ab3f2154))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants