fix: make sure to fall back to old query path when query job is incomplete #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plete (takes more than 10s)
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
============================================
+ Coverage 80.33% 80.40% +0.07%
- Complexity 1270 1271 +1
============================================
Files 79 79
Lines 6574 6573 -1
Branches 759 759
============================================
+ Hits 5281 5285 +4
+ Misses 897 893 -4
+ Partials 396 395 -1
Continue to review full report at Codecov.
|
epavan123
reviewed
Nov 12, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
epavan123
reviewed
Nov 12, 2020
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
Show resolved
Hide resolved
pmakani
approved these changes
Nov 13, 2020
epavan123
reviewed
Nov 13, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Show resolved
Hide resolved
epavan123
approved these changes
Nov 13, 2020
shollyman
approved these changes
Nov 13, 2020
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 13, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.124.6](https://www.github.com/googleapis/java-bigquery/compare/v1.124.5...v1.124.6) (2020-11-13) ### Bug Fixes * make sure to fall back to old query path when query job is incomplete ([#941](https://www.github.com/googleapis/java-bigquery/issues/941)) ([bd7d85c](https://www.github.com/googleapis/java-bigquery/commit/bd7d85c489cd260feeabbdc9ecbb8dcdc8d9ae77)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigtable to v1.17.3 ([#936](https://www.github.com/googleapis/java-bigquery/issues/936)) ([0b34a50](https://www.github.com/googleapis/java-bigquery/commit/0b34a5095b2bad4ac02b3d40937dd1a3ab3f2154)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the query job takes more than 10s we must fall back to the old query path!
cc @epavan