Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate bigquerydatatransfer from google-cloud-java, add bom #3

Merged
merged 5 commits into from Dec 5, 2019

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Dec 5, 2019

No description provided.

@googlebot googlebot added the cla: yes label Dec 5, 2019
@stephaniewang526 stephaniewang526 requested a review from chingor13 Dec 5, 2019
@stephaniewang526 stephaniewang526 changed the title add pom.xml chore: migrate bigquerydatatransfer from google-cloud-java Dec 5, 2019
@chingor13 chingor13 changed the title chore: migrate bigquerydatatransfer from google-cloud-java feat: migrate bigquerydatatransfer from google-cloud-java, add bom Dec 5, 2019
Copy link
Contributor

@chingor13 chingor13 left a comment

Ideally, we separate the regen changes from the template file changes

target/checkstyle-result.xml Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Dec 5, 2019

Codecov Report

No coverage uploaded for pull request base (master@f3cee8d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master    #3   +/-   ##
======================================
  Coverage          ?   75%           
  Complexity        ?   105           
======================================
  Files             ?     7           
  Lines             ?   920           
  Branches          ?    15           
======================================
  Hits              ?   690           
  Misses            ?   210           
  Partials          ?    20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3cee8d...df59ff4. Read the comment docs.

1. update synth to use new paths
2. update synth to use new copyright header
3. update pom.xml files to have correct names and descriptions
4. update .repo-metadata.json for new urls
5. add .gitignore
6. generate common templates
7. re-generate client
@stephaniewang526 stephaniewang526 requested a review from chingor13 Dec 5, 2019
@chingor13 chingor13 merged commit 32a90c4 into master Dec 5, 2019
13 checks passed
@chingor13 chingor13 deleted the fix-pom branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants