Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add create scheduled query with service account #322

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Sep 3, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and Sep 3, 2020
@google-cla google-cla bot added the cla: yes label Sep 3, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 3, 2020

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #322   +/-   ##
=========================================
  Coverage     74.68%   74.68%           
  Complexity      108      108           
=========================================
  Files             7        7           
  Lines           948      948           
  Branches         18       18           
=========================================
  Hits            708      708           
  Misses          220      220           
  Partials         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62ee9d...c5b3f09. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 35552a6 into googleapis:master Sep 3, 2020
17 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 3, 2020
@pmakani pmakani deleted the createschedule-query-serviceaccount branch Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants