This repository was archived by the owner on Sep 27, 2023. It is now read-only.
docs(samples): add run details#334
Merged
stephaniewang526 merged 3 commits intogoogleapis:masterfrom Sep 17, 2020
Merged
Conversation
google-cla
bot
added
the
cla: yes
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Comment on lines
+31
to
+33
| String runId = "MY_RUN_ID"; | ||
| // `projects/{project_id}/transferConfigs/{config_id}/runs/{run_id}` or | ||
| // `projects/{project_id}/locations/{location_id}/transferConfigs/{config_id}/runs/{run_id}` |
Contributor
There was a problem hiding this comment.
Suggested change
| String runId = "MY_RUN_ID"; | |
| // `projects/{project_id}/transferConfigs/{config_id}/runs/{run_id}` or | |
| // `projects/{project_id}/locations/{location_id}/transferConfigs/{config_id}/runs/{run_id}` | |
| // runId examples: | |
| // `projects/{project_id}/transferConfigs/{config_id}/runs/{run_id}` or | |
| // `projects/{project_id}/locations/{location_id}/transferConfigs/{config_id}/runs/{run_id}` | |
| String runId = "MY_RUN_ID"; |
lesv
approved these changes
Sep 9, 2020
Comment on lines
+42
to
+44
| } catch (ApiException ex) { | ||
| System.out.print("Run details not found." + ex.toString()); | ||
| } |
There was a problem hiding this comment.
Ok, but we prefer (Sample Format guide) that exceptions not be caught if you aren't going to actually do something with them.
| "SELECT CURRENT_TIMESTAMP() as current_time, @run_time as intended_run_time, " | ||
| + "@run_date as intended_run_date, 17 as some_integer"; | ||
| String destinationTableName = | ||
| "MY_DESTINATION_TABLE_" + UUID.randomUUID().toString().substring(0, 8) + "_{run_date}"; |
There was a problem hiding this comment.
This is probably ok, but some of those bits are actually constants. https://tools.ietf.org/html/rfc4122
| .setTransferConfig(transferConfig) | ||
| .build(); | ||
| name = dataTransferServiceClient.createTransferConfig(request).getName(); | ||
| System.out.println("\nScheduled query created successfully :" + name); |
There was a problem hiding this comment.
Hard coding the \n will be caught by various static analyzers.
product-auto-label
bot
added
the
api: bigquerydatatransfer
stephaniewang526
approved these changes
Sep 10, 2020
pmakani
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
|
Reaching out to DTS TL about quota issue: will be in touch about this one. |
stephaniewang526
added
the
do not merge
product-auto-label
bot
added
the
samples
Contributor
|
To address the quota issue, for all the DTS samples that involve dataset and scheduled query, let's use our newly created env vars: |
stephaniewang526
removed
the
do not merge
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
=========================================
Coverage 74.68% 74.68%
Complexity 108 108
=========================================
Files 7 7
Lines 948 948
Branches 18 18
=========================================
Hits 708 708
Misses 220 220
Partials 20 20 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: