Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add create redshift transfer config #507

merged 2 commits into from Nov 17, 2020


Copy link

@pmakani pmakani commented Nov 12, 2020

No description provided.

@pmakani pmakani requested review from stephaniewang526 and Nov 12, 2020
Copy link

@snippet-bot snippet-bot bot commented Nov 12, 2020

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
To update this comment, add snippet-bot:force-run label.

@product-auto-label product-auto-label bot added the api: bigquerydatatransfer label Nov 12, 2020
@google-cla google-cla bot added the cla: yes label Nov 12, 2020
Copy link

@codecov codecov bot commented Nov 12, 2020

Codecov Report

Merging #507 (ff38338) into master (a029038) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #507   +/-   ##
  Coverage     74.68%   74.68%           
  Complexity      108      108           
  Files             7        7           
  Lines           948      948           
  Branches         18       18           
  Hits            708      708           
  Misses          220      220           
  Partials         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a029038...ff38338. Read the comment docs.

Copy link

@stephaniewang526 stephaniewang526 commented Nov 12, 2020

We also need to set "dataset_region".
Here is a sample redshift transfer proto you can use as reference http://google3/cloud/helix/transfer/tools/new_region_validation/config_protos/create_redshift_transfer.textproto

Copy link

@stephaniewang526 stephaniewang526 commented Nov 16, 2020

LGTM - waiting on product team to get back on any additional feedback.

@product-auto-label product-auto-label bot added the samples label Nov 16, 2020
@stephaniewang526 stephaniewang526 merged commit 6c88965 into googleapis:master Nov 17, 2020
20 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 17, 2020
🤖 I have created a release \*beep\* \*boop\* 
### [1.0.19]( (2020-11-17)

### Dependencies

* update dependency to v1.124.4 ([#500]( ([7422ff7](
* update dependency to v1.124.5 ([#505]( ([c4d64d3](
* update dependency to v1.124.6 ([#512]( ([0e28a9c](
* update dependency to v1.124.7 ([#514]( ([6d064d4](
* update dependency to v0.15.0 ([#501]( ([9c9a540](
* update dependency to v3.14.0 ([#513]( ([c7f721e](

### Documentation

* **samples:** add create redshift transfer config ([#507]( ([6c88965](
* **samples:** add create teradata transfer ([#502]( ([8f3cce0](

This PR was generated with [Release Please](
@pmakani pmakani deleted the create-redshift-transfer branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: bigquerydatatransfer cla: yes samples
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants