Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

docs(samples): add create redshift transfer config #507

Merged
merged 2 commits into from
Nov 17, 2020
Merged

docs(samples): add create redshift transfer config #507

merged 2 commits into from
Nov 17, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Nov 12, 2020

No description provided.

@pmakani pmakani requested review from stephaniewang526 and a team November 12, 2020 13:24
@snippet-bot
Copy link

snippet-bot bot commented Nov 12, 2020 •
edited
Loading

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

@product-auto-label product-auto-label bot added the api: bigquerydatatransfer Issues related to the googleapis/java-bigquerydatatransfer API. label Nov 12, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020 •
edited
Loading

Codecov Report

Merging #507 (ff38338) into master (a029038) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #507   +/-   ##
=========================================
  Coverage     74.68%   74.68%           
  Complexity      108      108           
=========================================
  Files             7        7           
  Lines           948      948           
  Branches         18       18           
=========================================
  Hits            708      708           
  Misses          220      220           
  Partials         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a029038...ff38338. Read the comment docs.

@stephaniewang526
Copy link
Contributor

We also need to set "dataset_region".
Here is a sample redshift transfer proto you can use as reference http://google3/cloud/helix/transfer/tools/new_region_validation/config_protos/create_redshift_transfer.textproto

@stephaniewang526
Copy link
Contributor

LGTM - waiting on product team to get back on any additional feedback.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 16, 2020
@stephaniewang526 stephaniewang526 merged commit 6c88965 into googleapis:master Nov 17, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 17, 2020
@release-please
chore: release 1.0.19 (#503)
ae847ac 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.0.19](https://www.github.com/googleapis/java-bigquerydatatransfer/compare/v1.0.18...v1.0.19) (2020-11-17)


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.124.4 ([#500](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/500)) ([7422ff7](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/7422ff79fe9fb0e56c2a2ac788367148903e6033))
* update dependency com.google.cloud:google-cloud-bigquery to v1.124.5 ([#505](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/505)) ([c4d64d3](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/c4d64d3acda52d37f9a2eca19840faad710add71))
* update dependency com.google.cloud:google-cloud-bigquery to v1.124.6 ([#512](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/512)) ([0e28a9c](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/0e28a9c08eaf762a70bd2479c1e1f88897758e57))
* update dependency com.google.cloud:google-cloud-bigquery to v1.124.7 ([#514](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/514)) ([6d064d4](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/6d064d4e2a9c1103533bf5d96248691c215f6742))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.15.0 ([#501](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/501)) ([9c9a540](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/9c9a5403c617aa869b4563225f69078908f87f4d))
* update dependency com.google.protobuf:protobuf-java-util to v3.14.0 ([#513](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/513)) ([c7f721e](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/c7f721e014239c0d6dd4896db65f0a86f9e0602f))


### Documentation

* **samples:** add create redshift transfer config ([#507](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/507)) ([6c88965](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/6c88965c9fb6f6b9079e03b7b6aa6c466fb8570e))
* **samples:** add create teradata transfer ([#502](https://www.github.com/googleapis/java-bigquerydatatransfer/issues/502)) ([8f3cce0](https://www.github.com/googleapis/java-bigquerydatatransfer/commit/8f3cce0038745f7d2136117813e67e8299146791))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@pmakani pmakani deleted the create-redshift-transfer branch November 19, 2020 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
api: bigquerydatatransfer Issues related to the googleapis/java-bigquerydatatransfer API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmakani @stephaniewang526