Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update client documentation link #104

Merged
merged 1 commit into from Jul 17, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 17, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #101

@pmakani pmakani requested a review from stephaniewang526 Jul 17, 2020
@google-cla google-cla bot added the cla: yes label Jul 17, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 17, 2020

Codecov Report

Merging #104 into master will decrease coverage by 8.53%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
- Coverage     76.79%   68.26%   -8.54%     
+ Complexity      140      119      -21     
============================================
  Files             6        6              
  Lines          1155      690     -465     
  Branches          6        4       -2     
============================================
- Hits            887      471     -416     
+ Misses          230      198      -32     
+ Partials         38       21      -17     
Impacted Files Coverage Δ Complexity Δ
...vation/v1/stub/ReservationServiceStubSettings.java 76.99% <0.00%> (-5.25%) 28.00% <0.00%> (-1.00%)
...eservation/v1/stub/GrpcReservationServiceStub.java 93.82% <0.00%> (-3.25%) 25.00% <0.00%> (-1.00%)
...ery/reservation/v1/ReservationServiceSettings.java 10.93% <0.00%> (+0.16%) 2.00% <0.00%> (ø%)
...query/reservation/v1/ReservationServiceClient.java 63.54% <0.00%> (+1.64%) 60.00% <0.00%> (-19.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797f7dc...2e98ff8. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 474312e into googleapis:master Jul 17, 2020
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants