Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Commit 0d27d5a

Browse files
authored
fix: remove excessive StreamWriter info logging (#1359)
Fixing an internal feedback bug: b/202883481
1 parent 03f9d75 commit 0d27d5a

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ public void close() {
307307
} finally {
308308
this.lock.unlock();
309309
}
310-
log.info("Waiting for append thread to finish. Stream: " + streamName);
310+
log.fine("Waiting for append thread to finish. Stream: " + streamName);
311311
try {
312312
appendThread.join();
313313
log.info("User close complete. Stream: " + streamName);
@@ -366,17 +366,17 @@ private void appendLoop() {
366366
}
367367
}
368368

369-
log.info("Cleanup starts. Stream: " + streamName);
369+
log.fine("Cleanup starts. Stream: " + streamName);
370370
// At this point, the waiting queue is drained, so no more requests.
371371
// We can close the stream connection and handle the remaining inflight requests.
372372
this.streamConnection.close();
373373
waitForDoneCallback();
374374

375375
// At this point, there cannot be more callback. It is safe to clean up all inflight requests.
376-
log.info(
376+
log.fine(
377377
"Stream connection is fully closed. Cleaning up inflight requests. Stream: " + streamName);
378378
cleanupInflightRequests();
379-
log.info("Append thread is done. Stream: " + streamName);
379+
log.fine("Append thread is done. Stream: " + streamName);
380380
}
381381

382382
/*
@@ -396,7 +396,7 @@ private boolean waitingQueueDrained() {
396396
}
397397

398398
private void waitForDoneCallback() {
399-
log.info("Waiting for done callback from stream connection. Stream: " + streamName);
399+
log.fine("Waiting for done callback from stream connection. Stream: " + streamName);
400400
while (true) {
401401
this.lock.lock();
402402
try {
@@ -441,7 +441,7 @@ private void cleanupInflightRequests() {
441441
} finally {
442442
this.lock.unlock();
443443
}
444-
log.info(
444+
log.fine(
445445
"Cleaning "
446446
+ localQueue.size()
447447
+ " inflight requests with error: "
@@ -471,7 +471,7 @@ private void requestCallback(AppendRowsResponse response) {
471471
}
472472

473473
private void doneCallback(Throwable finalStatus) {
474-
log.info(
474+
log.fine(
475475
"Received done callback. Stream: "
476476
+ streamName
477477
+ " Final status: "

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ public void close() {
307307
} finally {
308308
this.lock.unlock();
309309
}
310-
log.info("Waiting for append thread to finish. Stream: " + streamName);
310+
log.fine("Waiting for append thread to finish. Stream: " + streamName);
311311
try {
312312
appendThread.join();
313313
log.info("User close complete. Stream: " + streamName);
@@ -366,17 +366,17 @@ private void appendLoop() {
366366
}
367367
}
368368

369-
log.info("Cleanup starts. Stream: " + streamName);
369+
log.fine("Cleanup starts. Stream: " + streamName);
370370
// At this point, the waiting queue is drained, so no more requests.
371371
// We can close the stream connection and handle the remaining inflight requests.
372372
this.streamConnection.close();
373373
waitForDoneCallback();
374374

375375
// At this point, there cannot be more callback. It is safe to clean up all inflight requests.
376-
log.info(
376+
log.fine(
377377
"Stream connection is fully closed. Cleaning up inflight requests. Stream: " + streamName);
378378
cleanupInflightRequests();
379-
log.info("Append thread is done. Stream: " + streamName);
379+
log.fine("Append thread is done. Stream: " + streamName);
380380
}
381381

382382
/*
@@ -396,7 +396,7 @@ private boolean waitingQueueDrained() {
396396
}
397397

398398
private void waitForDoneCallback() {
399-
log.info("Waiting for done callback from stream connection. Stream: " + streamName);
399+
log.fine("Waiting for done callback from stream connection. Stream: " + streamName);
400400
while (true) {
401401
this.lock.lock();
402402
try {
@@ -441,7 +441,7 @@ private void cleanupInflightRequests() {
441441
} finally {
442442
this.lock.unlock();
443443
}
444-
log.info(
444+
log.fine(
445445
"Cleaning "
446446
+ localQueue.size()
447447
+ " inflight requests with error: "
@@ -471,7 +471,7 @@ private void requestCallback(AppendRowsResponse response) {
471471
}
472472

473473
private void doneCallback(Throwable finalStatus) {
474-
log.info(
474+
log.fine(
475475
"Received done callback. Stream: "
476476
+ streamName
477477
+ " Final status: "

0 commit comments

Comments
 (0)