-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proto converter library #100
Conversation
modified: google-cloud-bigquerystorage/pom.xml new file: google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverter.java new file: google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoSchemaConverterTest.java new file: google-cloud-bigquerystorage/src/test/proto/test.proto modified: pom.xml
No, it is not. Without it, the project won't compile.
…On Thu, Mar 12, 2020 at 8:11 AM Stephanie Wang ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In google-cloud-bigquerystorage/pom.xml
<#100 (comment)>
:
> @@ -153,6 +179,10 @@
<classifier>testlib</classifier>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
is this a test dep? if not, maybe move it to be above the other test deps?
if so, maybe include <scope>test</scope>?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#100 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGYVEXBKHHMWVL47KTZ2BTRHD3TVANCNFSM4LFITKFA>
.
--
Thanks.
Yiru
|
Done. Adjust the orders.
…On Fri, Mar 13, 2020 at 5:50 AM Stephanie Wang ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#100 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGYVEWI2ZKIE2RIM2W5CTTRHITYRANCNFSM4LFITKFA>
.
--
Thanks.
Yiru
|
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
===========================================
- Coverage 72.36% 71.86% -0.5%
+ Complexity 281 270 -11
===========================================
Files 39 40 +1
Lines 1809 1784 -25
Branches 4 9 +5
===========================================
- Hits 1309 1282 -27
- Misses 496 497 +1
- Partials 4 5 +1
Continue to review full report at Codecov.
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
2 similar comments
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Your PR was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. See required reviews for your repo here: https://github.com/googleapis/sloth/blob/master/required-checks.json |
…08.0 (googleapis#100) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-storage](https://togithub.com/googleapis/java-storage) | minor | `1.107.0` -> `1.108.0` | --- ### Release Notes <details> <summary>googleapis/java-storage</summary> ### [`v1.108.0`](https://togithub.com/googleapis/java-storage/blob/master/CHANGELOG.md#​11080-httpswwwgithubcomgoogleapisjava-storagecomparev11070v11080-2020-04-30) [Compare Source](https://togithub.com/googleapis/java-storage/compare/v1.107.0...v1.108.0) ##### Features - add mockito dependency ([#​284](https://www.github.com/googleapis/java-storage/issues/284)) ([58692dd](https://www.github.com/googleapis/java-storage/commit/58692dd8eeb2d228d14c896e563184d723b25df1)) - V4 POST policy ([#​177](https://www.github.com/googleapis/java-storage/issues/177)) ([32d8ffa](https://www.github.com/googleapis/java-storage/commit/32d8fface1a994cb5ac928f08c0467edc3c9aab1)) ##### Bug Fixes - Documentation for Blob.update() and Storage.update() methods is confusing/incorrect ([#​261](https://www.github.com/googleapis/java-storage/issues/261)) ([876405f](https://www.github.com/googleapis/java-storage/commit/876405f81cf195f5619b353be8d1e8efcbf5e0b3)), closes [#​252](https://www.github.com/googleapis/java-storage/issues/252) ##### Dependencies - pin mockito version to work with java 7 ([#​292](https://www.github.com/googleapis/java-storage/issues/292)) ([8eb2fff](https://www.github.com/googleapis/java-storage/commit/8eb2fff3f51c90af7f76f74d40ed1d6d6b4320b7)) - update dependency com.google.api.grpc:grpc-google-cloud-kms-v1 to v0.85.1 ([#​273](https://www.github.com/googleapis/java-storage/issues/273)) ([7b5e7d1](https://www.github.com/googleapis/java-storage/commit/7b5e7d173cdac6b2de802c568e3a60b915d39d1c)) - update dependency com.google.api.grpc:proto-google-cloud-kms-v1 to v0.85.1 ([#​274](https://www.github.com/googleapis/java-storage/issues/274)) ([0ab4304](https://www.github.com/googleapis/java-storage/commit/0ab4304ea4e5e5668c05c67d2c96c6056f8c19c2)) - update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.10 ([#​281](https://www.github.com/googleapis/java-storage/issues/281)) ([f3dee7e](https://www.github.com/googleapis/java-storage/commit/f3dee7ea0d0e305f0bc0c980aa65e538f7bf890c)) - update dependency com.google.http-client:google-http-client-bom to v1.35.0 ([#​282](https://www.github.com/googleapis/java-storage/issues/282)) ([1c1c1be](https://www.github.com/googleapis/java-storage/commit/1c1c1bee0d6382e76e74f9a00dca8e527cc390c6)) - update dependency io.grpc:grpc-bom to v1.28.1 ([#​250](https://www.github.com/googleapis/java-storage/issues/250)) ([b35e81c](https://www.github.com/googleapis/java-storage/commit/b35e81ce19fa72672aefe8bd956959bfa954194c)) - update dependency io.grpc:grpc-bom to v1.29.0 ([#​275](https://www.github.com/googleapis/java-storage/issues/275)) ([9b241b4](https://www.github.com/googleapis/java-storage/commit/9b241b468d4f3a73b81c5bc67c085c6fe7c6ea1e)) - update dependency org.threeten:threetenbp to v1.4.4 ([#​278](https://www.github.com/googleapis/java-storage/issues/278)) ([7bae49f](https://www.github.com/googleapis/java-storage/commit/7bae49f16ba5de0eeac8301a6a11b85bd4406ed5)) ##### Documentation - label legacy storage classes in documentation ([#​267](https://www.github.com/googleapis/java-storage/issues/267)) ([50e5938](https://www.github.com/googleapis/java-storage/commit/50e5938147f7bb2594b9a142e8087c6e555f4979)), closes [#​254](https://www.github.com/googleapis/java-storage/issues/254) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-storage-nio).
🤖 I have created a release \*beep\* \*boop\* --- ### [0.120.1](https://www.github.com/googleapis/java-storage-nio/compare/v0.120.0...v0.120.1) (2020-06-16) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20200410-1.30.9 ([googleapis#97](https://www.github.com/googleapis/java-storage-nio/issues/97)) ([b86aed8](https://www.github.com/googleapis/java-storage-nio/commit/b86aed82b7959f2866d3430a4ab79f5983ea6e6f)) * update dependency com.google.apis:google-api-services-storage to v1-rev20200430-1.30.9 ([googleapis#110](https://www.github.com/googleapis/java-storage-nio/issues/110)) ([9350ed4](https://www.github.com/googleapis/java-storage-nio/commit/9350ed430c656fc3622025299008de934c80b99d)) * update dependency com.google.auto.value:auto-value to v1.7.1 ([googleapis#98](https://www.github.com/googleapis/java-storage-nio/issues/98)) ([3f07925](https://www.github.com/googleapis/java-storage-nio/commit/3f07925cb97b578774d721640588a83d3426b58d)) * update dependency com.google.auto.value:auto-value to v1.7.2 ([googleapis#104](https://www.github.com/googleapis/java-storage-nio/issues/104)) ([ff05184](https://www.github.com/googleapis/java-storage-nio/commit/ff05184b1c151ebea2dd45a818cdf5d65f437adc)) * update dependency com.google.auto.value:auto-value to v1.7.3 ([googleapis#131](https://www.github.com/googleapis/java-storage-nio/issues/131)) ([a225b87](https://www.github.com/googleapis/java-storage-nio/commit/a225b878e793e111390ce9e403b2a0018cff7c4c)) * update dependency com.google.auto.value:auto-value-annotations to v1.7.1 ([googleapis#99](https://www.github.com/googleapis/java-storage-nio/issues/99)) ([6aef5d6](https://www.github.com/googleapis/java-storage-nio/commit/6aef5d60f1d30e861b5ca6899f4942c3831c1bf8)) * update dependency com.google.auto.value:auto-value-annotations to v1.7.2 ([googleapis#105](https://www.github.com/googleapis/java-storage-nio/issues/105)) ([c0f3611](https://www.github.com/googleapis/java-storage-nio/commit/c0f36119bafbef4536f2ec66a8c417fe3eae624f)) * update dependency com.google.auto.value:auto-value-annotations to v1.7.3 ([googleapis#132](https://www.github.com/googleapis/java-storage-nio/issues/132)) ([3a46dd5](https://www.github.com/googleapis/java-storage-nio/commit/3a46dd59a3777aea490e6100a20425183d982cb3)) * update dependency com.google.cloud:google-cloud-core-bom to v1.93.5 ([googleapis#115](https://www.github.com/googleapis/java-storage-nio/issues/115)) ([7088962](https://www.github.com/googleapis/java-storage-nio/commit/70889626de81793e19c85b8c886dbea3456449d0)) * update dependency com.google.cloud:google-cloud-storage to v1.108.0 ([googleapis#100](https://www.github.com/googleapis/java-storage-nio/issues/100)) ([6a9a281](https://www.github.com/googleapis/java-storage-nio/commit/6a9a28105561d4408110d54bb92d4e1099ed7544)) * update dependency com.google.cloud:google-cloud-storage to v1.109.0 ([googleapis#133](https://www.github.com/googleapis/java-storage-nio/issues/133)) ([cb23faf](https://www.github.com/googleapis/java-storage-nio/commit/cb23faf0132db61bfdc8d0c6409dc9fa98ae2d11)) * update dependency com.google.http-client:google-http-client-bom to v1.35.0 ([googleapis#93](https://www.github.com/googleapis/java-storage-nio/issues/93)) ([0683dd2](https://www.github.com/googleapis/java-storage-nio/commit/0683dd21731b86d22a9d9f7201dad9deb1878d8a)) * update dependency com.google.protobuf:protobuf-bom to v3.12.0 ([googleapis#111](https://www.github.com/googleapis/java-storage-nio/issues/111)) ([4e592fb](https://www.github.com/googleapis/java-storage-nio/commit/4e592fb506a9b85c8d38c662605d4f97ad60b730)) * update dependency com.google.protobuf:protobuf-bom to v3.12.1 ([googleapis#114](https://www.github.com/googleapis/java-storage-nio/issues/114)) ([1b9b5e5](https://www.github.com/googleapis/java-storage-nio/commit/1b9b5e5a780f44abcba2b7eb25a2a46f5bf8c1ba)) * update dependency com.google.protobuf:protobuf-bom to v3.12.2 ([googleapis#116](https://www.github.com/googleapis/java-storage-nio/issues/116)) ([c297693](https://www.github.com/googleapis/java-storage-nio/commit/c297693dee0747d259ff1bcbc40d05218a782709)) ### Documentation * update CONTRIBUTING.md to include code formatting ([googleapis#534](https://www.github.com/googleapis/java-storage-nio/issues/534)) ([googleapis#103](https://www.github.com/googleapis/java-storage-nio/issues/103)) ([c329a58](https://www.github.com/googleapis/java-storage-nio/commit/c329a58086501f77d7c7e0db44eb06cb68eb933b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Add a client library addition to convert users schemas from the output of Descriptor.toProto to API acceptable ProtoSchema. This is needed for all users using the Write API.
The DescriptorProto needs to be self contained (contains all referenced type definition) so that server can reconstruct the schema from scratch.