Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove v1alpha2 library #1003

Merged
merged 6 commits into from Apr 15, 2021
Merged

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Apr 13, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from as code owners Apr 13, 2021
@yirutang yirutang requested a review from steffnay Apr 13, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Apr 13, 2021
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Apr 13, 2021

Warning: This pull request is touching the following templated files:

  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteClient.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/gapic_metadata.json
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/package-info.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/BigQueryWriteStub.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/BigQueryWriteStubSettings.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/GrpcBigQueryWriteCallableFactory.java
  • google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteClientTest.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/MockBigQueryWrite.java
  • google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/MockBigQueryWriteImpl.java
  • grpc-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/BigQueryWriteGrpc.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/ProtoBufProto.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Storage.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Stream.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Table.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/TableName.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriteStreamName.java
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/proto/google/cloud/bigquery/storage/v1alpha2/protobuf.proto
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/proto/google/cloud/bigquery/storage/v1alpha2/storage.proto
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/proto/google/cloud/bigquery/storage/v1alpha2/stream.proto
  • proto-google-cloud-bigquerystorage-v1alpha2/src/main/proto/google/cloud/bigquery/storage/v1alpha2/table.proto

@google-cla google-cla bot added the cla: yes label Apr 13, 2021
@yirutang yirutang changed the title feat! remove v1alpha2 library refactor! remove v1alpha2 library Apr 13, 2021
@stephaniewang526 stephaniewang526 changed the title refactor! remove v1alpha2 library refactor!: remove v1alpha2 library Apr 13, 2021
@yirutang yirutang changed the title refactor!: remove v1alpha2 library refactor! remove v1alpha2 library Apr 13, 2021
@yirutang yirutang changed the title refactor! remove v1alpha2 library refactor!: remove v1alpha2 library Apr 13, 2021
@codecov
Copy link

@codecov codecov bot commented Apr 13, 2021

Codecov Report

Merging #1003 (c05d179) into master (88fa5f8) will decrease coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1003      +/-   ##
============================================
- Coverage     81.03%   80.00%   -1.03%     
+ Complexity     1045      709     -336     
============================================
  Files            78       61      -17     
  Lines          5668     3961    -1707     
  Branches        435      264     -171     
============================================
- Hits           4593     3169    -1424     
+ Misses          889      669     -220     
+ Partials        186      123      -63     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fa5f8...c05d179. Read the comment docs.

@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 13, 2021
Copy link
Member

@stephaniewang526 stephaniewang526 left a comment

We also need to remove it from the bom, versions.txt and synth.py.

Copy link
Member

@stephaniewang526 stephaniewang526 left a comment

Can we remove the ! from the initial commit?

@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Apr 14, 2021

Can we remove the ! from the initial commit?

done. I thought I already did it somehow...

@stephaniewang526 stephaniewang526 merged commit 98cd924 into googleapis:master Apr 15, 2021
16 of 18 checks passed
@release-please release-please bot mentioned this pull request Apr 15, 2021
@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Apr 15, 2021

@yirutang yirutang deleted the remove branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants