Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove schema update capability from jsonwriter and delete related tests #1047

Merged
merged 3 commits into from May 4, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Apr 30, 2021

…ted tests

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Apr 30, 2021
@yirutang yirutang requested a review from stephaniewang526 Apr 30, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Apr 30, 2021
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@codecov
Copy link

@codecov codecov bot commented May 4, 2021

Codecov Report

Merging #1047 (4610ea9) into master (b100b63) will decrease coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1047      +/-   ##
============================================
- Coverage     80.19%   79.49%   -0.70%     
+ Complexity      710      701       -9     
============================================
  Files            61       61              
  Lines          3963     3945      -18     
  Branches        264      264              
============================================
- Hits           3178     3136      -42     
- Misses          661      684      +23     
- Partials        124      125       +1     
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 68.04% <ø> (-8.49%) 11.00 <0.00> (-3.00)
...gquery/storage/v1beta2/OnSchemaUpdateRunnable.java 0.00% <ø> (-85.72%) 0.00 <0.00> (-4.00)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 80.73% <0.00%> (-3.22%) 31.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b100b63...4610ea9. Read the comment docs.

@yirutang
Copy link
Contributor Author

@yirutang yirutang commented May 4, 2021

@stephaniewang526 stephaniewang526 merged commit 21e399b into googleapis:master May 4, 2021
17 of 18 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants