Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate json writer to use StreamWriterV2 #1058

Merged
merged 11 commits into from May 11, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented May 7, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner May 7, 2021
@yirutang yirutang requested review from and shollyman May 7, 2021
@google-cla google-cla bot added the cla: yes label May 7, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label May 7, 2021
@codecov
Copy link

@codecov codecov bot commented May 7, 2021

Codecov Report

Merging #1058 (650f13c) into master (121da18) will decrease coverage by 0.00%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1058      +/-   ##
============================================
- Coverage     79.49%   79.48%   -0.01%     
+ Complexity      701      700       -1     
============================================
  Files            61       61              
  Lines          3945     3944       -1     
  Branches        264      266       +2     
============================================
- Hits           3136     3135       -1     
  Misses          684      684              
  Partials        125      125              
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 64.58% <55.55%> (-3.46%) 10.00 <0.00> (-1.00)
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 81.42% <0.00%> (+0.68%) 31.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 121da18...650f13c. Read the comment docs.

@yirutang yirutang requested a review from as a code owner May 7, 2021
@yirutang yirutang requested a review from steffnay May 8, 2021
@shollyman shollyman requested review from stephaniewang526 and removed request for shollyman and steffnay May 10, 2021
@@ -3,27 +3,8 @@
<differences>
<!-- Allow below protobuf changes as non-breaking-->
<difference>
<differenceType>8001</differenceType>
Copy link
Member

@stephaniewang526 stephaniewang526 May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't remove any of these existing <difference>s since they are needed to allow protobuf changes to be non-breaking.

@stephaniewang526 stephaniewang526 merged commit 586777f into googleapis:master May 11, 2021
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants