fix: More robust STREAM_RST logic #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquerystorage
google-cla
bot
added
the
cla: yes
kmjung
approved these changes
May 27, 2021
| return status.getCode() == Status.Code.INTERNAL | ||
| && status.getDescription() != null | ||
| && (status.getDescription().contains("Received unexpected EOS on DATA frame from server") | ||
| || status.getDescription().contains("Received Rst ") |
There was a problem hiding this comment.
Nit: is there a reason to drop " Stream" here?
There was a problem hiding this comment.
Yes, from PR description:
The capitalization of "Rst Stream" isn't clear, other repose have it lower cased: (e.g. https://github.com/googleapis/java-bigtable-hbase/pull/3000/files)
|
Please update initial commit and subject line of this PR to abide by conventional commit rules. |
stephaniewang526
suggested changes
May 30, 2021
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/util/Errors.java
Outdated
Show resolved
Hide resolved
Comment on lines
34
to
35
| || status.getDescription().contains("Received Rst ") | ||
| || status.getDescription().contains("RST_STREAM")); |
There was a problem hiding this comment.
Can we just check for status.getDescription.toLowercase().contains("rst")?
There was a problem hiding this comment.
I don't think so. "rst" can occur naturally in other settings. I shortened the top one to just be " Rst ". I also added some other messages from spark-bigquery-connector.
There was a problem hiding this comment.
okay lgtm thank you!
...e-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/util/ErrorsTest.java
Outdated
Show resolved
Hide resolved
…gquery/storage/util/Errors.java Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
…gquery/storage/util/ErrorsTest.java Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
emkornfield
changed the title
stephaniewang526
approved these changes
May 31, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 31, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.22.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.21.1...v2.0.0) (2021-05-31) ### ⚠ BREAKING CHANGES * remove default deadline for AppendRows API (#1101) ### Features * add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#1092](https://www.github.com/googleapis/java-bigquerystorage/issues/1092)) ([9fe34d1](https://www.github.com/googleapis/java-bigquerystorage/commit/9fe34d1a7ea2b4c1f750fd8805251811a4b0111d)) ### Bug Fixes * More robust STREAM_RST logic ([#1102](https://www.github.com/googleapis/java-bigquerystorage/issues/1102)) ([dd67534](https://www.github.com/googleapis/java-bigquerystorage/commit/dd675343b20d614eaf715306f1151532a3a2c33f)) * remove default deadline for AppendRows API ([#1101](https://www.github.com/googleapis/java-bigquerystorage/issues/1101)) ([87cadf0](https://www.github.com/googleapis/java-bigquerystorage/commit/87cadf01edbdaf876699e98f027835d6594f8072)) ### Dependencies * update arrow.version to v4.0.1 ([#1103](https://www.github.com/googleapis/java-bigquerystorage/issues/1103)) ([b2e3489](https://www.github.com/googleapis/java-bigquerystorage/commit/b2e34894f443075ce375b822babcfc329b34c76c)) * update dependency com.google.truth:truth to v1.1.3 ([#1100](https://www.github.com/googleapis/java-bigquerystorage/issues/1100)) ([12c401f](https://www.github.com/googleapis/java-bigquerystorage/commit/12c401feec1fb7fbaf39ea7ccffee4a02faffeb3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
davidrabinowitz
added a commit
to davidrabinowitz/spark-bigquery-connector
that referenced
this pull request
Jun 1, 2021
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
This change makes error matching against stream rst more robust. Customers have started to see other variants with RST stream. The capitalization of "Rst Stream" isn't clear, other repose have it lower cased: (e.g. https://github.com/googleapis/java-bigtable-hbase/pull/3000/files)