Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call awaitTermination when close the stream writer #1111

Merged
merged 1 commit into from Jun 5, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Jun 4, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Jun 4, 2021
@yirutang yirutang requested a review from stephaniewang526 Jun 4, 2021
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Jun 4, 2021
@reuvenlax
Copy link

@reuvenlax reuvenlax commented Jun 4, 2021

LGTM

@yirutang yirutang changed the title fix:call awaitTermination when close the stream writer fix: call awaitTermination when close the stream writer Jun 4, 2021
@stephaniewang526 stephaniewang526 merged commit 0f7db50 into googleapis:master Jun 5, 2021
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants