Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make EOS Matching more robust #1128

Merged
merged 2 commits into from Jun 11, 2021

Conversation

emkornfield
Copy link
Contributor

@emkornfield emkornfield commented Jun 11, 2021

fix: Make EOS Matching more robust

Clients are seeing a different variant now: Received unexpected EOS on empty DATA frame from server

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

fix: Make EOS Matching more robust

Clients are seeing a different variant now: Received unexpected EOS on empty DATA frame from server
@emkornfield emkornfield requested a review from as a code owner Jun 11, 2021
@emkornfield emkornfield requested a review from shollyman Jun 11, 2021
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Jun 11, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: bigquerystorage label Jun 11, 2021
@google-cla google-cla bot added the cla: yes label Jun 11, 2021
emkornfield referenced this issue in grpc/grpc-java Jun 11, 2021
Empty DATA frames with EOS tell a stronger tale as to where the server
may have its bug.
@emkornfield
Copy link
Contributor Author

@emkornfield emkornfield commented Jun 11, 2021

It looks like grpc/grpc-java@60d3e7c broke the logic

@emkornfield
Copy link
Contributor Author

@emkornfield emkornfield commented Jun 11, 2021

@stephaniewang526 would you mind taking a look.

@emkornfield
Copy link
Contributor Author

@emkornfield emkornfield commented Jun 11, 2021

Integration test failure looks related to the write functionality

@shollyman shollyman added the kokoro:force-run label Jun 11, 2021
@shollyman
Copy link
Contributor

@shollyman shollyman commented Jun 11, 2021

re-running to get around the loadshed failure

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 11, 2021
@shollyman shollyman added automerge kokoro:force-run labels Jun 11, 2021
@shollyman
Copy link
Contributor

@shollyman shollyman commented Jun 11, 2021

Still getting loadshedding responses from the write backend

@shollyman shollyman added kokoro:force-run and removed kokoro:force-run labels Jun 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3b5cdbe into googleapis:master Jun 11, 2021
17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants