Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flatten plugin #117

Merged
merged 14 commits into from Apr 4, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Mar 23, 2020

add flatten plugin to flatten pom.xml

@googlebot googlebot added the cla: yes label Mar 23, 2020
@stephaniewang526 stephaniewang526 requested a review from chingor13 Mar 23, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Mar 23, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 23, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Mar 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 24, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Mar 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 27, 2020
@codecov
Copy link

@codecov codecov bot commented Apr 2, 2020

Codecov Report

Merging #117 into master will increase coverage by 2.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     71.86%   73.88%   +2.02%     
- Complexity      270      319      +49     
============================================
  Files            40       42       +2     
  Lines          1784     2229     +445     
  Branches          9       70      +61     
============================================
+ Hits           1282     1647     +365     
- Misses          497      552      +55     
- Partials          5       30      +25
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/storage/v1alpha2/Waiter.java 72.54% <0%> (ø) 14% <0%> (?)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 81.17% <0%> (ø) 28% <0%> (?)
...igquery/storage/v1alpha2/ProtoSchemaConverter.java 93.54% <0%> (+0.21%) 6% <0%> (ø) ⬇️
...y/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java 93.69% <0%> (+0.9%) 12% <0%> (+1%) ⬆️
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 61.29% <0%> (+9.67%) 14% <0%> (+2%) ⬆️
...gquery/storage/v1alpha2/BigQueryWriteSettings.java 29.72% <0%> (+10.81%) 6% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e41dd0a...d90fe3e. Read the comment docs.

@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 3, 2020
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 3, 2020
@stephaniewang526 stephaniewang526 changed the title feat: add samples module and flatten plugin feat: add flatten plugin Apr 3, 2020
@stephaniewang526 stephaniewang526 requested a review from chingor13 Apr 3, 2020
@stephaniewang526 stephaniewang526 requested a review from elharo Apr 3, 2020
Copy link
Contributor

@chingor13 chingor13 left a comment

If this works well for us here, we should move all these configs into the shared-config parent.

elharo
elharo approved these changes Apr 3, 2020
@stephaniewang526 stephaniewang526 merged commit c01bbc7 into googleapis:master Apr 4, 2020
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants