Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept null json values in JsonToProtoMessage converter #1288

Merged
merged 3 commits into from Sep 3, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Sep 3, 2021

Fixes #1258 ☕️

@yirutang yirutang requested a review from as a code owner Sep 3, 2021
@yirutang yirutang requested a review from tswast Sep 3, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Sep 3, 2021
@google-cla google-cla bot added the cla: yes label Sep 3, 2021
@stephaniewang526 stephaniewang526 added owlbot:run automerge labels Sep 3, 2021
@yirutang yirutang requested a review from as a code owner Sep 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Sep 3, 2021
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Sep 3, 2021

could you see if the test case needs to be updated?

Error:  Errors: 
Error:    StreamWriterTest.testFlowControlBehaviorBlockAbortOnShutdown:984 » NullPointer

Full trace

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Sep 3, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Sep 3, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run label Sep 3, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Sep 3, 2021
@stephaniewang526 stephaniewang526 added the automerge label Sep 3, 2021
@stephaniewang526 stephaniewang526 merged commit fb515ab into googleapis:master Sep 3, 2021
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Sep 3, 2021
gcf-owl-bot bot added a commit that referenced this issue Nov 29, 2021
* deps: upgrade google-java-format to 1.11.0

Fixes googleapis/synthtool#1287

google-java-format 1.11.0 is the version used by fmt-maven-plugin 2.12
(latest as of November 2021).

* ci: owlbot to use Java 11

* formatter version through the java-shared-config

* updating container_test.yaml
Source-Link: googleapis/synthtool@fdf20ea
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:55d5d3c72e1c065f018e423e122a22fb55c8daa36f6f17f540774779ed659ab9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants