Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): Add WriteAPI BUFFERED mode sample #1338

Merged
merged 4 commits into from Oct 4, 2021

Conversation

VeronicaWasson
Copy link
Contributor

@VeronicaWasson VeronicaWasson commented Sep 30, 2021

Adds a sample for using the JsonStreamWriter in buffered mode.

@product-auto-label product-auto-label bot added the api: bigquerystorage label Sep 30, 2021
@snippet-bot
Copy link

@snippet-bot snippet-bot bot commented Sep 30, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples label Sep 30, 2021
@google-cla google-cla bot added the cla: yes label Sep 30, 2021

@Test
public void testWriteBufferedStream() throws Exception {
WriteBufferedStream.writeBufferedStream(GOOGLE_CLOUD_PROJECT, datasetName, tableName);
Copy link
Contributor

@yirutang yirutang Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a query to verify rows are there?

Copy link
Contributor Author

@VeronicaWasson VeronicaWasson Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

.setWriteStream(writeStream.getName())
.setOffset(Int64Value.of(10 * 2 - 1)) // Advance the cursor to the latest record.
.build();
FlushRowsResponse flushRowsResponse = client.flushRows(flushRowsRequest);
Copy link
Contributor

@yirutang yirutang Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add another write without flush and comment that those rows will not appear in the table.

Copy link
Contributor Author

@VeronicaWasson VeronicaWasson Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this would some unneeded complexity to the sample, and also make it harder to compare the differences with pending and committed modes. Also it would make the code not strictly correct, if a user didn't read the code comments carefully.

@stephaniewang526 stephaniewang526 added the owlbot:run label Sep 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Sep 30, 2021
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Sep 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 30, 2021
@VeronicaWasson VeronicaWasson requested review from as code owners Sep 30, 2021
@VeronicaWasson VeronicaWasson requested a review from stephaniewang526 (assigned from googleapis/api-bigquery) Sep 30, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run label Oct 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 1, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run owlbot:run labels Oct 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 1, 2021
@stephaniewang526 stephaniewang526 requested a review from yirutang Oct 1, 2021
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Oct 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 1, 2021
@parthea parthea added the owlbot:run label Oct 4, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 4, 2021
@eaball35 eaball35 merged commit 5dfd523 into googleapis:main Oct 4, 2021
18 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 6, 2021
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.3](https://www.github.com/googleapis/java-bigquerystorage/compare/v2.3.2...v2.3.3) (2021-10-05)


### Bug Fixes

* add string to DATETIME, TIME, NUMERIC, BIGNUMERIC support in JsonStreamWriter v1 ([#1345](https://www.github.com/googleapis/java-bigquerystorage/issues/1345)) ([9d272dd](https://www.github.com/googleapis/java-bigquerystorage/commit/9d272dd711dfe8909a7b421dabdcdef30f1dc689))
* JsonWriter accepts string input for DATETIME, TIME, NUMERIC, BIGNUMERIC field ([#1339](https://www.github.com/googleapis/java-bigquerystorage/issues/1339)) ([691f078](https://www.github.com/googleapis/java-bigquerystorage/commit/691f078f09e32fa7784d4afeeee0e8071f78d6fd))
* Sample should show sending multiple rows in one request ([#1335](https://www.github.com/googleapis/java-bigquerystorage/issues/1335)) ([3f85a68](https://www.github.com/googleapis/java-bigquerystorage/commit/3f85a68d6812aac94ca8a266d76be2aa94cd0b32))


### Documentation

* **samples:** Add WriteAPI BUFFERED mode sample ([#1338](https://www.github.com/googleapis/java-bigquerystorage/issues/1338)) ([5dfd523](https://www.github.com/googleapis/java-bigquerystorage/commit/5dfd5231c1ffa68a1b92ba01a9608d8cee2c0596))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v2.2.0 ([#1346](https://www.github.com/googleapis/java-bigquerystorage/issues/1346)) ([9370eb8](https://www.github.com/googleapis/java-bigquerystorage/commit/9370eb8ea74547792f9597d20707546836c417b6))
* update dependency com.google.cloud:google-cloud-bigquery to v2.2.1 ([#1347](https://www.github.com/googleapis/java-bigquerystorage/issues/1347)) ([406f5d3](https://www.github.com/googleapis/java-bigquerystorage/commit/406f5d3d446d3a9639b2c95590b3c6c38118d741))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants