Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BQ/proto schema names should be compared lowercase #1369

Conversation

stephenjudkins
Copy link
Contributor

@stephenjudkins stephenjudkins commented Oct 19, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1366☕️

@stephenjudkins stephenjudkins requested a review from as a code owner Oct 19, 2021
@stephenjudkins stephenjudkins requested a review from tswast (assigned from googleapis/api-bigquery) Oct 19, 2021
@google-cla google-cla bot added the cla: yes label Oct 19, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Oct 19, 2021
@stephenjudkins stephenjudkins force-pushed the sdj/1366/fix-mixed-case-fieldnames branch from 71ea3d2 to 374160b Compare Oct 19, 2021
@stephaniewang526 stephaniewang526 requested a review from yirutang Oct 19, 2021
Copy link
Contributor

@yirutang yirutang left a comment

Thanks for fixing this, looks good. Could you add a test case to capture this change?

@stephenjudkins stephenjudkins requested a review from as a code owner Oct 20, 2021
@stephenjudkins stephenjudkins force-pushed the sdj/1366/fix-mixed-case-fieldnames branch from 62f440b to 7e602d9 Compare Oct 20, 2021
@stephenjudkins stephenjudkins changed the title BQ/proto schema names should be compared lowercase fixBQ/proto schema names should be compared lowercase Oct 20, 2021
@stephenjudkins stephenjudkins changed the title fixBQ/proto schema names should be compared lowercase fix: BQ/proto schema names should be compared lowercase Oct 20, 2021
@stephenjudkins
Copy link
Contributor Author

@stephenjudkins stephenjudkins commented Oct 20, 2021

@yirutang test added

Copy link
Member

@stephaniewang526 stephaniewang526 left a comment

Please fix lint failure by running mvn com.coveo:fmt-maven-plugin:format and pushing the change

@stephaniewang526 stephaniewang526 added the automerge label Oct 21, 2021
@stephenjudkins
Copy link
Contributor Author

@stephenjudkins stephenjudkins commented Oct 21, 2021

Appreciate the 👍 ! Thank you for your help.

We'd love to see a minor release ASAP, as this is a bit of a blocker for us. Thank you!

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Oct 22, 2021

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 22, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run label Oct 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 25, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run owlbot:run labels Oct 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 25, 2021
@stephaniewang526 stephaniewang526 added the automerge label Oct 25, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run label Oct 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 25, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run label Oct 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 25, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run owlbot:run labels Oct 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 25, 2021
@generated-files-bot
Copy link

@generated-files-bot generated-files-bot bot commented Oct 25, 2021

Warning: This pull request is touching the following templated files:

  • .kokoro/dependencies.sh

@stephaniewang526 stephaniewang526 added owlbot:run and removed automerge labels Oct 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 25, 2021
@stephaniewang526 stephaniewang526 added kokoro:force-run owlbot:run labels Oct 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Oct 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Oct 25, 2021
@stephaniewang526 stephaniewang526 added the automerge label Oct 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit a0da90e into googleapis:main Oct 25, 2021
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 25, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 26, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.5.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v2.4.2...v2.5.0) (2021-10-26)


### Features

* next release from main branch is 2.4.1 ([#1376](https://www.github.com/googleapis/java-bigquerystorage/issues/1376)) ([ca21447](https://www.github.com/googleapis/java-bigquerystorage/commit/ca21447e56dacbe2cec4722f037d441479ec2a8f))


### Bug Fixes

* BQ/proto schema names should be compared lowercase ([#1369](https://www.github.com/googleapis/java-bigquerystorage/issues/1369)) ([a0da90e](https://www.github.com/googleapis/java-bigquerystorage/commit/a0da90e8de89c5b9ef77183fee86e1e1a7389e00))


### Dependencies

* update arrow.version to v6 ([#1383](https://www.github.com/googleapis/java-bigquerystorage/issues/1383)) ([f2e3562](https://www.github.com/googleapis/java-bigquerystorage/commit/f2e3562fc1ed0a1a1e71c077dc6d37ae3fe6b3be))
* update dependency com.google.cloud:google-cloud-bigquery to v2.3.2 ([#1378](https://www.github.com/googleapis/java-bigquerystorage/issues/1378)) ([5983419](https://www.github.com/googleapis/java-bigquerystorage/commit/5983419a0d71849787876ecb5715c919f6ce04f9))
* update dependency com.google.cloud:google-cloud-bigquery to v2.3.3 ([#1382](https://www.github.com/googleapis/java-bigquerystorage/issues/1382)) ([8705af7](https://www.github.com/googleapis/java-bigquerystorage/commit/8705af7a11aa6a8f8182193011fc8bc7c4a28a4f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants