Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: waitForTermination in the manual client #140 #141

Merged
merged 6 commits into from Apr 7, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Apr 4, 2020

Fixes #140 ☕️

After the fix, close() should fully work. So I updated the unit test to use close().
Also fixed a issue in reconnection.

@googlebot googlebot added the cla: yes label Apr 4, 2020
@yirutang yirutang changed the title Fix waitForTermination in the manual client. fix: #140 waitForTermination in the manual client. Apr 4, 2020
@stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Apr 4, 2020

Please correct initial commit msg to "fix: waitForTermination" so that conventionalcommit check will pass. FYI, this is also what's used in triggering our release pipeline.

@stephaniewang526 stephaniewang526 self-requested a review Apr 4, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 4, 2020
@stephaniewang526 stephaniewang526 changed the title fix: #140 waitForTermination in the manual client. fix: waitForTermination in the manual client #140 Apr 6, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 6, 2020
@stephaniewang526 stephaniewang526 merged commit bdb8e0f into googleapis:master Apr 7, 2020
12 checks passed
@yirutang yirutang deleted the fix-2 branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants