Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add reconnect support to v1 client lib. #1446

Merged
merged 10 commits into from Dec 20, 2021

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Dec 9, 2021

Change ported from internal java client lib. I've fixed up our stress test, removed the reconnection from the test and ran the test for several 12 hour periods. The test verifies we got all requests coming back to us and I saw reconnections happens several times during my run.

Also, removed some unused test lib functionalities.

@yirutang yirutang requested a review from as a code owner Dec 9, 2021
@yirutang yirutang requested a review from loferris (assigned from googleapis/api-bigquery) Dec 9, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage label Dec 9, 2021
@stephaniewang526 stephaniewang526 added the owlbot:run label Dec 10, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run label Dec 10, 2021
@yirutang yirutang requested a review from as a code owner Dec 10, 2021
@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Dec 14, 2021

As Yi suggested, will add a special backend feature to allow more stressful testing on the reconnect case.

@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Dec 16, 2021

I am running a 5 day stress test. Should have enough confidence of this PR when the test is done.

@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Dec 19, 2021

Stress test finished:
Start time: 15:07:52.911109 (unfortunately, the test used LocalTime instead of LocalDateTime)
Finish Time: 15:51:47.980477
Total Elapsed Time: PT43M55.069368S
Total Requests: 1062867462
Total Failed Responses: 238
Total unexpected reconnect: 0

StreamWriter reconnect 99 times in total.

@stephaniewang526 stephaniewang526 merged commit a5157fa into googleapis:main Dec 20, 2021
18 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 4, 2022
🤖 I have created a release \*beep\* \*boop\*
---
## [2.8.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v2.7.0...v2.8.0) (2021-12-30)


### Features

* Add ignoreUnknownField support in JsonWriter ([#1455](https://www.github.com/googleapis/java-bigquerystorage/issues/1455)) ([4616adb](https://www.github.com/googleapis/java-bigquerystorage/commit/4616adb30d07d7be522b74837adae080eca103a6))
* Add reconnect support to v1 client lib. ([#1446](https://www.github.com/googleapis/java-bigquerystorage/issues/1446)) ([a5157fa](https://www.github.com/googleapis/java-bigquerystorage/commit/a5157faf37354ee48a0af930a68edf4823b5be6f))
* add schema update support in JsonStreamWriter ([#1447](https://www.github.com/googleapis/java-bigquerystorage/issues/1447)) ([973afcc](https://www.github.com/googleapis/java-bigquerystorage/commit/973afccc22507b8109b3920d3fc183692dcc66c2))
* support `append()` without offset in `StreamWriter` ([#1452](https://www.github.com/googleapis/java-bigquerystorage/issues/1452)) ([cb8b0ad](https://www.github.com/googleapis/java-bigquerystorage/commit/cb8b0ad25fbf07c3509b3d94244a999b9cb90e54))


### Bug Fixes

* allow all fields to be null values ([#1450](https://www.github.com/googleapis/java-bigquerystorage/issues/1450)) ([e47ac79](https://www.github.com/googleapis/java-bigquerystorage/commit/e47ac791765486f02f027d3c440645ef2a379ba9))
* finish BIGNUMERIC support ([#1449](https://www.github.com/googleapis/java-bigquerystorage/issues/1449)) ([d9d51cd](https://www.github.com/googleapis/java-bigquerystorage/commit/d9d51cd203733a972c80e312e9e279b50fb260fa))
* fix a NullPtr when user closes a writer without connection being ever established ([#1454](https://www.github.com/googleapis/java-bigquerystorage/issues/1454)) ([b774f5d](https://www.github.com/googleapis/java-bigquerystorage/commit/b774f5d0d00275278708d1299b4912b455be4bed))
* update storageError support due to server side enhancement ([#1456](https://www.github.com/googleapis/java-bigquerystorage/issues/1456)) ([6243ad5](https://www.github.com/googleapis/java-bigquerystorage/commit/6243ad5cba61d4dae7f4ceb60b09c625e7589215))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants