Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: several StreamWriter issues #213

Merged
merged 3 commits into from Apr 24, 2020
Merged

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Apr 23, 2020

  • Make messages wait in flow control to be delivered in order
  • Avoid recreating the BigQueryWriteClient stub during reconnection, which is not necessary.
  • Allow user to pass in BigQueryWriteClient stub so that it can be shared with other API calls.

Fixes #<issue_number_goes_here> ☕️

@googlebot googlebot added the cla: yes label Apr 23, 2020
- Make messages wait in flow controll to be delivered in order
- Avoid recreating the BigQueryWriteClient stub during reconnection, which is not necessary.
- Allow user to pass in BigQueryWriteClient stub so that it can be shared with other API calls.

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Waiter.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 24, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 24, 2020
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Waiter.java
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Apr 24, 2020
@stephaniewang526 stephaniewang526 merged commit b803863 into googleapis:master Apr 24, 2020
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants