Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

fix: several StreamWriter issues#213

Merged
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
yirutang:fix-e2e
Apr 24, 2020
Merged

fix: several StreamWriter issues#213
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
yirutang:fix-e2e

Conversation

@yirutang
Copy link
Contributor

@yirutang yirutang commented Apr 23, 2020

  • Make messages wait in flow control to be delivered in order
  • Avoid recreating the BigQueryWriteClient stub during reconnection, which is not necessary.
  • Allow user to pass in BigQueryWriteClient stub so that it can be shared with other API calls.

Fixes #<issue_number_goes_here> ☕️

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2020
- Make messages wait in flow controll to be delivered in order
- Avoid recreating the BigQueryWriteClient stub during reconnection, which is not necessary.
- Allow user to pass in BigQueryWriteClient stub so that it can be shared with other API calls.

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Waiter.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/Waiter.java
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@stephaniewang526 stephaniewang526 merged commit b803863 into googleapis:master Apr 24, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…oogleapis#213)

Automatically perform a Java client library release when:
1. Only dependency updates are going out in the release since any releases containing bug fixes, build changes or new features should be supervised;
2. There are no outstanding/open dependency update pull requests in the repo. This is to avoid multiple/redundant releases;
3. It is a SNAPSHOT release which is automatically generated post regular release -- this requires no human supervision.

Testing done in 5 java-bigquery* client library repos. Example:
[chore: release 0.3.4 ](googleapis/java-bigqueryconnection#130)
[chore: release 0.3.5-SNAPSHOT](googleapis/java-bigqueryconnection#131)

Source-Author: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Source-Date: Thu Sep 17 15:30:02 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 538a68019eb4a36a0cdfa4021f324dd01b784395
Source-Link: googleapis/synthtool@538a680
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants