Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky writeapi manual client tests #238

Merged
merged 2 commits into from May 1, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented May 1, 2020

  1. There are some warnings in the test runs saying that open connections are not closed. Make sure everything is shutdown after test.
  2. There is some unexpected exceptions thrown which is not caught. Now catch a more general exception and also fix some issues that incorrectly calling remove on List (which is not supported).
  3. Make sure the executor in the tests are finished running, so it will not run into a race with test shutdown.

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/DirectWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriterCache.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/DirectWriterTest.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/WriterCacheTest.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/it/ITBigQueryWriteManualClientTest.java
@googlebot googlebot added the cla: yes label May 1, 2020
@yirutang yirutang changed the title fix: flaky tests fix: flaky writeapi manual client tests May 1, 2020
@codecov
Copy link

@codecov codecov bot commented May 1, 2020

Codecov Report

Merging #238 into master will increase coverage by 0.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #238      +/-   ##
============================================
+ Coverage     74.02%   74.93%   +0.91%     
- Complexity      346      369      +23     
============================================
  Files            45       45              
  Lines          2387     2462      +75     
  Branches         89       97       +8     
============================================
+ Hits           1767     1845      +78     
+ Misses          575      574       -1     
+ Partials         45       43       -2     
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/DirectWriter.java 79.31% <100.00%> (+1.53%) 5.00 <1.00> (+1.00)
...e/cloud/bigquery/storage/v1alpha2/WriterCache.java 90.90% <100.00%> (+2.19%) 14.00 <3.00> (+4.00)
...rage/v1beta1/stub/EnhancedBigQueryStorageStub.java 86.27% <0.00%> (+0.27%) 9.00% <0.00%> (+1.00%)
...orage/v1alpha2/stub/BigQueryWriteStubSettings.java 81.57% <0.00%> (+0.32%) 14.00% <0.00%> (ø%)
...y/storage/v1alpha2/stub/GrpcBigQueryWriteStub.java 95.00% <0.00%> (+0.40%) 14.00% <0.00%> (+1.00%)
...uery/storage/v1/stub/EnhancedBigQueryReadStub.java 82.92% <0.00%> (+0.42%) 7.00% <0.00%> (+1.00%)
...storage/v1beta2/stub/EnhancedBigQueryReadStub.java 82.92% <0.00%> (+0.42%) 7.00% <0.00%> (+1.00%)
...rage/v1beta1/stub/BigQueryStorageStubSettings.java 84.72% <0.00%> (+0.43%) 14.00% <0.00%> (ø%)
.../storage/v1beta1/stub/GrpcBigQueryStorageStub.java 93.12% <0.00%> (+0.50%) 12.00% <0.00%> (+1.00%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74c0ce...9181269. Read the comment docs.

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/DirectWriter.java
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/WriterCache.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/DirectWriterTest.java
@stephaniewang526 stephaniewang526 added automerge kokoro:run labels May 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run label May 1, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 89c8623 into googleapis:master May 1, 2020
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants