Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid setting error on response future twice #261

Merged
merged 2 commits into from May 8, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented May 7, 2020

There is a test flakiness that sometimes, we get unexpected StatusUnknown error set from stream closed. It could be a error race that the second error overrides the first error.

@googlebot googlebot added the cla: yes label May 7, 2020
@codecov
Copy link

@codecov codecov bot commented May 7, 2020

Codecov Report

Merging #261 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
- Coverage     74.35%   74.33%   -0.02%     
- Complexity      376      377       +1     
============================================
  Files            45       45              
  Lines          2515     2525      +10     
  Branches         98      100       +2     
============================================
+ Hits           1870     1877       +7     
- Misses          594      596       +2     
- Partials         51       52       +1     
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 83.21% <66.66%> (-0.32%) 35.00 <4.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b99ddd...3cfc65e. Read the comment docs.

@yirutang yirutang force-pushed the error-twice branch 5 times, most recently from d4f82c7 to 6915cce Compare May 7, 2020
	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
@stephaniewang526 stephaniewang526 added the kokoro:force-run label May 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 8, 2020
@stephaniewang526 stephaniewang526 merged commit 35ef0ed into googleapis:master May 8, 2020
12 of 14 checks passed
@yirutang yirutang deleted the error-twice branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants