Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add retry logic for readrows #263

Merged
merged 3 commits into from May 26, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented May 8, 2020

Fixes #86

@googlebot googlebot added the cla: yes label May 8, 2020
@pmakani pmakani requested a review from stephaniewang526 May 8, 2020
@pmakani pmakani added the kokoro:force-run label May 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 8, 2020
@codecov
Copy link

@codecov codecov bot commented May 8, 2020

Codecov Report

Merging #263 into master will increase coverage by 0.60%.
The diff coverage is 83.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #263      +/-   ##
============================================
+ Coverage     74.16%   74.76%   +0.60%     
- Complexity      382      410      +28     
============================================
  Files            45       48       +3     
  Lines          2570     2754     +184     
  Branches        101      126      +25     
============================================
+ Hits           1906     2059     +153     
- Misses          610      624      +14     
- Partials         54       71      +17     
Impacted Files Coverage Δ Complexity Δ
...rage/v1/stub/readrows/ApiResultRetryAlgorithm.java 78.26% <78.26%> (ø) 9.00 <9.00> (?)
...rage/v1/stub/readrows/ReadRowsAttemptCallable.java 78.94% <78.94%> (ø) 16.00 <16.00> (?)
...age/v1/stub/readrows/ReadRowsRetryingCallable.java 95.23% <95.23%> (ø) 2.00 <2.00> (?)
...uery/storage/v1/stub/EnhancedBigQueryReadStub.java 88.05% <96.55%> (+5.13%) 8.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de1c24d...90c66bb. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 50345b6 into googleapis:master May 26, 2020
14 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue May 27, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.133.1](https://www.github.com/googleapis/java-bigquerystorage/compare/v0.133.0...v0.133.1) (2020-05-27)


### Bug Fixes

* add retry logic for readrows ([#263](https://www.github.com/googleapis/java-bigquerystorage/issues/263)) ([50345b6](https://www.github.com/googleapis/java-bigquerystorage/commit/50345b653d59209b7912b56b76c6d41e289ecb30))


### Dependencies

* bump shared-deps version and add back certain test deps ([#300](https://www.github.com/googleapis/java-bigquerystorage/issues/300)) ([edfa26b](https://www.github.com/googleapis/java-bigquerystorage/commit/edfa26bb5bfa506004a6d3e39775f9f66b956db9))
* update dependency com.google.cloud:google-cloud-bigquery to v1.115.1 ([#294](https://www.github.com/googleapis/java-bigquerystorage/issues/294)) ([75a08c3](https://www.github.com/googleapis/java-bigquerystorage/commit/75a08c3683fde88264d310f965a0c973b54dfd9e))
* update dependency com.google.cloud:google-cloud-bigquery to v1.116.0 ([#296](https://www.github.com/googleapis/java-bigquerystorage/issues/296)) ([d243ece](https://www.github.com/googleapis/java-bigquerystorage/commit/d243ece29dd1494531f623b69e609fb833e970dc))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.4.0 ([#291](https://www.github.com/googleapis/java-bigquerystorage/issues/291)) ([20b2963](https://www.github.com/googleapis/java-bigquerystorage/commit/20b2963bbf315951d1607bee63a7aa083cdb6c86))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@pmakani pmakani deleted the internal-retrying branch May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants