Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flush API to StreamWriter #278

Merged
merged 2 commits into from May 15, 2020
Merged

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented May 13, 2020

Add a flush method to StreamWriter. The implementation is void, so just added boilerplate unit test and e2e test.

@googlebot googlebot added the cla: yes label May 13, 2020
@yirutang yirutang force-pushed the flush branch 3 times, most recently from 587ac05 to 88c5539 Compare May 13, 2020
Add a flush method to client library. The implementation is void, so just added boilerplate unit test and e2e test.

	modified:   google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/FakeBigQueryWrite.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/FakeBigQueryWriteImpl.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
	modified:   google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/it/ITBigQueryWriteManualClientTest.java
@stephaniewang526 stephaniewang526 added the kokoro:force-run label May 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 14, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label May 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 15, 2020
@stephaniewang526 stephaniewang526 merged commit f617259 into googleapis:master May 15, 2020
12 checks passed
@yirutang yirutang deleted the flush branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants