Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added BQSchemaToProtoDescriptor.java #395

Merged
merged 13 commits into from
Jul 7, 2020
Merged

feat: Added BQSchemaToProtoDescriptor.java #395

merged 13 commits into from
Jul 7, 2020

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Jul 1, 2020 •
edited
Loading

Add class that converts from BQ Table Schema to Protocol Buffer Descriptor.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020 •
edited
Loading

Codecov Report

Merging #395 into master will increase coverage by 0.37%.
The diff coverage is 98.46%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #395      +/-   ##
============================================
+ Coverage     76.40%   76.77%   +0.37%     
- Complexity      556      564       +8     
============================================
  Files            54       55       +1     
  Lines          3263     3328      +65     
  Branches        197      201       +4     
============================================
+ Hits           2493     2555      +62     
- Misses          660      662       +2     
- Partials        110      111       +1
Impacted Files Coverage Δ Complexity Δ
...orage/v1alpha2/BQTableSchemaToProtoDescriptor.java 98.46% <98.46%> (ø) 8.00 <8.00> (?)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 79.90% <0.00%> (-0.47%) 33.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9d4c8...c8569dc. Read the comment docs.

yirutang
yirutang reviewed Jul 6, 2020
View reviewed changes
...rystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoConverter.java Outdated Show resolved Hide resolved
...rystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoConverter.java Outdated Show resolved Hide resolved
...rystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoConverter.java Outdated Show resolved Hide resolved
...orage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoConverterTest.java Outdated Show resolved Hide resolved
...orage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoConverterTest.java Outdated Show resolved Hide resolved
...orage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoConverterTest.java Outdated Show resolved Hide resolved
...orage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoConverterTest.java Outdated Show resolved Hide resolved
@allenc3 allenc3 changed the title feat: Added BQSchema to ProtoSchema conversion in JsonToProtoConverter.java feat: Added BQSchemaToProtoDescriptor.java Jul 6, 2020
allenc3 added 13 commits July 7, 2020 13:56
@allenc3
feat: Added BQSchemaToProtoSchema functionality along with test cases…
3583f11 
…; checked for linting
@allenc3
Updated BQ Numeric mapping from proto double to proto string to preve…
57cb6cf 
…nt data loss
@allenc3
Updated BQ Numeric mapping from proto string to proto bytes to match …
cbe007f 
…backend mapping
@allenc3
Revert pom.xml
1685876
@allenc3
Fix according to PR conversations
d3a621c
@allenc3
Fix according to PR conversations and checked linting
eea28b4
@allenc3
Renamed from JsonToProtoConvereter to BQTableSchemaToProtoDescriptor.…
5ed3b9b 
… This is to split it up to two classes.
@allenc3
Linting
c0e8685
@allenc3
make sure tests work and rename is good
a6d786c
@allenc3
Renamed functions
8dcb1c2
@allenc3
Fixed bugs according to PR, added descriptor reuse (instead of creati…
8f6ee9b 
…ng the same descriptor again) and a test case that checks for this.
@allenc3
Update documentation
bdcaa22
@allenc3
Merge ConvertBQTableFieldToProtoField and ConvertBQStructToProtoMsg
c8569dc
@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 7, 2020
@allenc3 allenc3 marked this pull request as ready for review July 7, 2020 19:39
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c3a9542 into googleapis:master Jul 7, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 11, 2020
@release-please
chore: release 1.1.0 (#399)
1afd9fe 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.1.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.0.0...v1.1.0) (2020-07-10)


### Features

* add two new fields, ignoreUnknownFields in AppendRowsRequest and update_schema in AppendRowsResponse. ([#389](https://www.github.com/googleapis/java-bigquerystorage/issues/389)) ([3e9d4c8](https://www.github.com/googleapis/java-bigquerystorage/commit/3e9d4c8abae73b25894d330a99e4213057777bc8))
* Added BQSchemaToProtoDescriptor.java ([#395](https://www.github.com/googleapis/java-bigquerystorage/issues/395)) ([c3a9542](https://www.github.com/googleapis/java-bigquerystorage/commit/c3a9542b146c2a95bd69e6bb940e02f72354141c))


### Dependencies

* update dependency com.fasterxml.jackson.core:jackson-core to v2.11.1 ([#383](https://www.github.com/googleapis/java-bigquerystorage/issues/383)) ([004e78b](https://www.github.com/googleapis/java-bigquerystorage/commit/004e78be6e5de02ce83ef95e5a40c0f23f4b11a0))
* update dependency com.google.cloud:google-cloud-bigquery to v1.116.4 ([#404](https://www.github.com/googleapis/java-bigquerystorage/issues/404)) ([dd56e6c](https://www.github.com/googleapis/java-bigquerystorage/commit/dd56e6c2e9fca51d569a700b4d0bb9527b1e347c))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#393](https://www.github.com/googleapis/java-bigquerystorage/issues/393)) ([4d3bce6](https://www.github.com/googleapis/java-bigquerystorage/commit/4d3bce618f39b44048ee20ed47b1cd61354117ad))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#405](https://www.github.com/googleapis/java-bigquerystorage/issues/405)) ([01c59e2](https://www.github.com/googleapis/java-bigquerystorage/commit/01c59e26c6c5f8bc42112aa89a90da5786343efc))
* update dependency org.apache.avro:avro to v1.10.0 ([#392](https://www.github.com/googleapis/java-bigquerystorage/issues/392)) ([25dd6d5](https://www.github.com/googleapis/java-bigquerystorage/commit/25dd6d54e129cfb4e0f87f9f05abe4314a01a0dd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
2c70858 
…onfig to v0.10.0 (googleapis#395)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `0.9.4` -> `0.10.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.10.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.10.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.10.0/compatibility-slim/0.9.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/0.10.0/confidence-slim/0.9.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v0.10.0`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#&#8203;0100-httpswwwgithubcomgoogleapisjava-shared-configcomparev094v0100-2021-01-21)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v0.9.4...v0.10.0)

##### Features

-   adding pom profile to generate docfx yml from javadoc ([#&#8203;213](https://www.github.com/googleapis/java-shared-config/issues/213)) ([3527c47](https://www.github.com/googleapis/java-shared-config/commit/3527c47ff413d415f87fccca84358da2c837841d))

##### Dependencies

-   update dependency com.puppycrawl.tools:checkstyle to v8.39 ([#&#8203;209](https://www.github.com/googleapis/java-shared-config/issues/209)) ([fb53922](https://www.github.com/googleapis/java-shared-config/commit/fb539226d407001822a56c7fff792922cd85d1fe))

##### [0.9.4](https://www.github.com/googleapis/java-shared-config/compare/v0.9.3...v0.9.4) (2020-10-21)

##### Documentation

-   Latest for Cloud-RAD ([#&#8203;199](https://www.github.com/googleapis/java-shared-config/issues/199)) ([34712af](https://www.github.com/googleapis/java-shared-config/commit/34712afac58aa0d148f0843026b3ff770ee030c2))

##### [0.9.3](https://www.github.com/googleapis/java-shared-config/compare/v0.9.2...v0.9.3) (2020-10-15)

##### Dependencies

-   update auto-value-annotation.version to v1.7.4 ([#&#8203;157](https://www.github.com/googleapis/java-shared-config/issues/157)) ([5d7e394](https://www.github.com/googleapis/java-shared-config/commit/5d7e394d964010a3e32af492cec4be85aabc3ebf))

##### [0.9.2](https://www.github.com/googleapis/java-shared-config/compare/v0.9.1...v0.9.2) (2020-07-02)

##### Dependencies

-   update dependency org.apache.maven.surefire:surefire-junit47 to v3.0.0-M5 ([#&#8203;180](https://www.github.com/googleapis/java-shared-config/issues/180)) ([802d9c5](https://www.github.com/googleapis/java-shared-config/commit/802d9c528d34b386face69ca75a014ce57fc3ac1))

##### [0.9.1](https://www.github.com/googleapis/java-shared-config/compare/v0.9.0...v0.9.1) (2020-07-01)

##### Bug Fixes

-   maven-dependency-plugin configuration breaking downstream config ([#&#8203;174](https://www.github.com/googleapis/java-shared-config/issues/174)) ([507217f](https://www.github.com/googleapis/java-shared-config/commit/507217fe509cd4f16eb50c8075ab43229238e08d))

##### Documentation

-   change Devsite output path to /java/docs/reference ([#&#8203;176](https://www.github.com/googleapis/java-shared-config/issues/176)) ([8b98af5](https://www.github.com/googleapis/java-shared-config/commit/8b98af54bf503d97bb86b6d02a5c4301b39384e1))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage-nio).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

@yirutang yirutang yirutang approved these changes

@Wilson720 Wilson720 Wilson720 approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@allenc3 @stephaniewang526 @yirutang @Wilson720 @googlebot @yoshi-kokoro