Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BQTableSchemaToProtoDescriptor change type mapping #402

Merged
merged 4 commits into from Jul 14, 2020

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Jul 9, 2020

Change BQ Date to map to Proto Int32.

@googlebot googlebot added the cla: yes label Jul 9, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 9, 2020

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #402   +/-   ##
=========================================
  Coverage     76.92%   76.92%           
  Complexity      565      565           
=========================================
  Files            55       55           
  Lines          3328     3328           
  Branches        201      201           
=========================================
  Hits           2560     2560           
  Misses          659      659           
  Partials        109      109           
Impacted Files Coverage Δ Complexity Δ
...orage/v1alpha2/BQTableSchemaToProtoDescriptor.java 98.46% <100.00%> (ø) 8.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c571b...6ae111f. Read the comment docs.

@allenc3 allenc3 marked this pull request as ready for review Jul 13, 2020
@stephaniewang526 stephaniewang526 added the automerge label Jul 13, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Jul 13, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Jul 14, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Jul 14, 2020
@stephaniewang526 stephaniewang526 added kokoro:force-run automerge labels Jul 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 413d6f0 into googleapis:master Jul 14, 2020
15 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 14, 2020
yirutang pushed a commit to yirutang/java-bigquerystorage that referenced this issue Jul 16, 2020
yirutang pushed a commit to yirutang/java-bigquerystorage that referenced this issue Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants