Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BQTableSchemaToProtobufDescriptor will now only generate lower-cased fieldnames in the protobuf descriptor #415

Merged
merged 5 commits into from Jul 16, 2020

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Jul 14, 2020

Since the backend is case-insensitive, letting all fieldnames be lowercased in the generated protobuf descriptor can save some space/time while using the generated descriptor to create a protobuf message from JSON.

@googlebot googlebot added the cla: yes label Jul 14, 2020
@allenc3 allenc3 force-pushed the FixBQToProto branch 2 times, most recently from 727c354 to 27166c4 Compare Jul 14, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 14, 2020

Codecov Report

Merging #415 into master will increase coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #415      +/-   ##
============================================
+ Coverage     76.83%   77.30%   +0.47%     
- Complexity      564      574      +10     
============================================
  Files            55       55              
  Lines          3328     3367      +39     
  Branches        201      198       -3     
============================================
+ Hits           2557     2603      +46     
+ Misses          661      660       -1     
+ Partials        110      104       -6     
Impacted Files Coverage Δ Complexity Δ
...orage/v1alpha2/BQTableSchemaToProtoDescriptor.java 98.46% <100.00%> (ø) 8.00 <0.00> (ø)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 80.60% <0.00%> (+0.23%) 34.00% <0.00%> (+1.00%)
...uery/storage/v1/stub/BigQueryReadStubSettings.java 85.27% <0.00%> (+0.59%) 12.00% <0.00%> (ø%)
...storage/v1beta2/stub/BigQueryReadStubSettings.java 85.27% <0.00%> (+0.59%) 12.00% <0.00%> (ø%)
...orage/v1alpha2/stub/BigQueryWriteStubSettings.java 85.52% <0.00%> (+3.41%) 15.00% <0.00%> (ø%)
...rage/v1/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <0.00%> (+8.69%) 12.00% <0.00%> (+3.00%)
...v1beta1/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <0.00%> (+8.69%) 12.00% <0.00%> (+3.00%)
...v1beta2/stub/readrows/ApiResultRetryAlgorithm.java 86.95% <0.00%> (+8.69%) 12.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb00729...2a09ee5. Read the comment docs.

@allenc3 allenc3 marked this pull request as draft Jul 15, 2020
@allenc3 allenc3 changed the title fix: BQTableSchemaToProtobufDescriptor will now only generate lower-cased fieldnames in the protobuf descriptor. fix: BQTableSchemaToProtobufDescriptor will now only generate lower-cased fieldnames in the protobuf descriptor Jul 15, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jul 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 15, 2020
@allenc3 allenc3 marked this pull request as ready for review Jul 15, 2020
@stephaniewang526 stephaniewang526 added kokoro:force-run automerge labels Jul 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 15, 2020
@gcf-merge-on-green
Copy link

@gcf-merge-on-green gcf-merge-on-green bot commented Jul 15, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@stephaniewang526 stephaniewang526 removed the automerge label Jul 15, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run label Jul 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jul 16, 2020
@stephaniewang526 stephaniewang526 merged commit 4672939 into googleapis:master Jul 16, 2020
15 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.2.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.1.1...v1.2.0) (2020-07-16)


### Features

* add 'Received Rst Stream' to automatic retry strings ([#419](https://www.github.com/googleapis/java-bigquerystorage/issues/419)) ([1584bdb](https://www.github.com/googleapis/java-bigquerystorage/commit/1584bdbf5820a378d844d333e8546b6a26b3c643))


### Bug Fixes

* BQTableSchemaToProtobufDescriptor will now only generate lower-cased fieldnames in the protobuf descriptor ([#415](https://www.github.com/googleapis/java-bigquerystorage/issues/415)) ([4672939](https://www.github.com/googleapis/java-bigquerystorage/commit/46729398eee0f728c3de731f803580342fbe787f))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yirutang pushed a commit to yirutang/java-bigquerystorage that referenced this issue Jul 16, 2020
…ased fieldnames in the protobuf descriptor (googleapis#415)

* fix: all protofields in the generated descriptor will be lowercased

* Remove debug output

* Test commits

* Reverted test commit

* No-op
yirutang pushed a commit to yirutang/java-bigquerystorage that referenced this issue Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants