Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing resource name deps to v1beta1 #436

Merged
merged 1 commit into from Jul 21, 2020

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Jul 21, 2020

These dependencies were not added to the pom.xml by the generator when resource name classes were added. I'm not sure why that is, but it will fix the CI errors in #435. I tested this locally and noted it in the config change.

@google-cla google-cla bot added the cla: yes label Jul 21, 2020
@noahdietz
Copy link
Contributor Author

@noahdietz noahdietz commented Jul 21, 2020

@kmjung
Copy link
Contributor

@kmjung kmjung commented Jul 21, 2020

@noahdietz
Copy link
Contributor Author

@noahdietz noahdietz commented Jul 21, 2020

I don't have merge permissions it seems, so feel free to whenever you're ready.

@stephaniewang526 stephaniewang526 merged commit bf384ea into googleapis:autosynth-googleapis Jul 21, 2020
11 checks passed
stephaniewang526 pushed a commit that referenced this issue Jul 21, 2020
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* feat: migrate bq/storage/v1beta1 to gapic v2

- adds new resource name classes

PiperOrigin-RevId: 322235422

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Jul 20 15:14:29 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: d7a347b819096886f4644b0ed5a978a777f4bbb4
Source-Link: googleapis/googleapis@d7a347b

* fix: add missing resource name deps to v1beta1 (#436)

Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants