Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enum value conflict in generated ProtoSchema descriptor. #469

Merged
merged 2 commits into from Aug 6, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Aug 5, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

yoshi-automation and others added 2 commits Aug 5, 2020
autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@google-cla google-cla bot added the cla: yes label Aug 5, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 6, 2020

Codecov Report

Merging #469 into master will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #469      +/-   ##
============================================
+ Coverage     78.00%   78.21%   +0.21%     
- Complexity      624      625       +1     
============================================
  Files            56       56              
  Lines          3551     3549       -2     
  Branches        235      233       -2     
============================================
+ Hits           2770     2776       +6     
+ Misses          675      668       -7     
+ Partials        106      105       -1     
Impacted Files Coverage Δ Complexity Δ
...igquery/storage/v1alpha2/ProtoSchemaConverter.java 96.22% <100.00%> (+14.40%) 10.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012f071...1a67baa. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 3e1382f into googleapis:master Aug 6, 2020
14 of 15 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 7, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.4.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.3.1...v1.4.0) (2020-08-07)


### Features

* add JsonStreamWriter ([#475](https://www.github.com/googleapis/java-bigquerystorage/issues/475)) ([341bf99](https://www.github.com/googleapis/java-bigquerystorage/commit/341bf99d47d788ebabaa1ce775d1a4f527ee46b0))


### Bug Fixes

* enum value conflict in generated ProtoSchema descriptor. ([#469](https://www.github.com/googleapis/java-bigquerystorage/issues/469)) ([3e1382f](https://www.github.com/googleapis/java-bigquerystorage/commit/3e1382f247de5e6ee8727130280e34fa01d3c088)), closes [#464](https://www.github.com/googleapis/java-bigquerystorage/issues/464)


### Dependencies

* update dependency com.fasterxml.jackson.core:jackson-core to v2.11.2 ([#461](https://www.github.com/googleapis/java-bigquerystorage/issues/461)) ([36b368a](https://www.github.com/googleapis/java-bigquerystorage/commit/36b368a14bb7d45f92af23bc0dd6fe08ad79b085))
* update dependency com.google.cloud:google-cloud-bigquery to v1.116.9 ([#473](https://www.github.com/googleapis/java-bigquerystorage/issues/473)) ([b4ba055](https://www.github.com/googleapis/java-bigquerystorage/commit/b4ba055a809dbe414e8e19d377b8257d0b5446d6))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.5 ([#467](https://www.github.com/googleapis/java-bigquerystorage/issues/467)) ([35c65d4](https://www.github.com/googleapis/java-bigquerystorage/commit/35c65d466d44d01e6f7626ef7cf1aa0e9f3ff0f3))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@yirutang yirutang deleted the protoconvert branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants