Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a flushAll() method that will flush all the inflight request and make sure all responses returned #492

Merged
merged 17 commits into from Aug 19, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Aug 14, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@google-cla google-cla bot added the cla: yes label Aug 14, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 14, 2020

Codecov Report

Merging #492 into master will increase coverage by 0.56%.
The diff coverage is 85.10%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #492      +/-   ##
============================================
+ Coverage     78.11%   78.67%   +0.56%     
- Complexity      642      662      +20     
============================================
  Files            58       59       +1     
  Lines          3687     3789     +102     
  Branches        235      255      +20     
============================================
+ Hits           2880     2981     +101     
- Misses          687      692       +5     
+ Partials        120      116       -4     
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/storage/v1alpha2/Waiter.java 57.14% <33.33%> (-0.69%) 14.00 <4.00> (+2.00) ⬇️
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 84.17% <92.68%> (+1.95%) 39.00 <4.00> (+4.00)
.../cloud/bigquery/storage/v1alpha2/DirectWriter.java 77.55% <0.00%> (-3.10%) 6.00% <0.00%> (+1.00%) ⬇️
...oud/bigquery/storage/v1alpha2/JsonWriterCache.java 87.93% <0.00%> (ø) 12.00% <0.00%> (?%)
...ud/bigquery/storage/v1alpha2/JsonStreamWriter.java 77.39% <0.00%> (+0.19%) 13.00% <0.00%> (+1.00%)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 60.34% <0.00%> (+1.72%) 19.00% <0.00%> (ø%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 43.90% <0.00%> (+2.43%) 10.00% <0.00%> (ø%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 43.90% <0.00%> (+2.43%) 10.00% <0.00%> (ø%)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 58.57% <0.00%> (+5.71%) 28.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28dace8...c6529a1. Read the comment docs.

@yirutang yirutang changed the title feat: Add a flushAll() method that will flush all the inflight request and make sure all responses returned. feat: Add a flushAll() method that will flush all the inflight request and make sure all responses returned Aug 14, 2020
@yirutang
Copy link
Contributor Author

@yirutang yirutang commented Aug 17, 2020

@stephaniewang526 stephaniewang526 merged commit 6134818 into googleapis:master Aug 19, 2020
15 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 19, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.5.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.4.1...v1.5.0) (2020-08-19)


### Features

* Add a flushAll() method that will flush all the inflight request and make sure all responses returned ([#492](https://www.github.com/googleapis/java-bigquerystorage/issues/492)) ([6134818](https://www.github.com/googleapis/java-bigquerystorage/commit/6134818f7bc5ada324a78d5c048bb2eeb83f8ca8))
* add JsonWriterCache.java and added JsonWriterCache in DirectWriter to allow JsonWrites ([#489](https://www.github.com/googleapis/java-bigquerystorage/issues/489)) ([34193b8](https://www.github.com/googleapis/java-bigquerystorage/commit/34193b88bcf64b97dbcde2183e7587fa44923d4b))


### Dependencies

* update dependency com.google.cloud:google-cloud-bigquery to v1.116.10 ([#483](https://www.github.com/googleapis/java-bigquerystorage/issues/483)) ([285b6f8](https://www.github.com/googleapis/java-bigquerystorage/commit/285b6f846753f387800d2787746ddb43de67a4b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@yirutang yirutang deleted the flush branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants