fix:update schema compat check with backend type changes #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
============================================
- Coverage 78.68% 78.60% -0.08%
- Complexity 662 663 +1
============================================
Files 59 59
Lines 3790 3786 -4
Branches 255 253 -2
============================================
- Hits 2982 2976 -6
- Misses 692 693 +1
- Partials 116 117 +1
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: bigquerystorage
stephaniewang526
reviewed
Sep 8, 2020
| @@ -348,6 +343,9 @@ private void protoFieldTypeIsCompatibleWithBQFieldType( | |||
| case "NUMERIC": | |||
| match = isCompatibleWithBQNumeric(protoType); | |||
| break; | |||
| case "BIGNUMERIC": | |||
| match = isCompatibleWithBQNumeric(protoType); | |||
There was a problem hiding this comment.
please add test for this
There was a problem hiding this comment.
Removed it for now, it seems the value is not available in external library yet.
stephaniewang526
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here>☕️