Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:update schema compat check with backend type changes #522

Merged
merged 2 commits into from Sep 8, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Sep 4, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@google-cla google-cla bot added the cla: yes label Sep 4, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 4, 2020

Codecov Report

Merging #522 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #522      +/-   ##
============================================
- Coverage     78.68%   78.60%   -0.08%     
- Complexity      662      663       +1     
============================================
  Files            59       59              
  Lines          3790     3786       -4     
  Branches        255      253       -2     
============================================
- Hits           2982     2976       -6     
- Misses          692      693       +1     
- Partials        116      117       +1     
Impacted Files Coverage Δ Complexity Δ
...bigquery/storage/v1alpha2/SchemaCompatibility.java 91.30% <100.00%> (-0.22%) 99.00 <5.00> (+1.00) ⬇️
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 83.75% <0.00%> (-0.43%) 39.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30d52e...d3a2898. Read the comment docs.

@product-auto-label product-auto-label bot added the api: bigquerystorage label Sep 5, 2020
@@ -348,6 +343,9 @@ private void protoFieldTypeIsCompatibleWithBQFieldType(
case "NUMERIC":
match = isCompatibleWithBQNumeric(protoType);
break;
case "BIGNUMERIC":
match = isCompatibleWithBQNumeric(protoType);
Copy link
Member

@stephaniewang526 stephaniewang526 Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test for this

Copy link
Contributor Author

@yirutang yirutang Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it for now, it seems the value is not available in external library yet.

@stephaniewang526 stephaniewang526 merged commit 2fcae4f into googleapis:master Sep 8, 2020
14 of 16 checks passed
@yirutang yirutang deleted the compatfix branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants