-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump dependency versions #53
Conversation
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
Coverage 71.11% 71.11%
Complexity 197 197
=========================================
Files 28 28
Lines 1357 1357
Branches 3 3
=========================================
Hits 965 965
Misses 389 389
Partials 3 3 Continue to review full report at Codecov.
|
@@ -105,7 +105,7 @@ | |||
<dependency> | |||
<groupId>com.google.cloud</groupId> | |||
<artifactId>google-cloud-bigquery</artifactId> | |||
<version>1.102.0</version> | |||
<version>1.106.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely the upgrade that's causing the issues. I'd try splitting this out into a separate PR to isolate it.
@@ -108,6 +110,16 @@ | |||
<artifactId>grpc-google-cloud-bigquerystorage-v1beta2</artifactId> | |||
<version>0.85.2-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-bigquerystorage-v1beta2:current} --> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to add these two. Just move avro to the end of your dependencies section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe not. The avro dependency on jackson is not as deep.
…o v1-rev20200226-1.30.9 (googleapis#53)
Fixes #31 #51 #52