Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump dependency versions #53

Merged
merged 1 commit into from Feb 3, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Feb 3, 2020

Fixes #31 #51 #52

@googlebot googlebot added the cla: yes label Feb 3, 2020
@stephaniewang526 stephaniewang526 requested a review from elharo Feb 3, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 3, 2020

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     71.11%   71.11%           
  Complexity      197      197           
=========================================
  Files            28       28           
  Lines          1357     1357           
  Branches          3        3           
=========================================
  Hits            965      965           
  Misses          389      389           
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bf682...be21311. Read the comment docs.

@@ -105,7 +105,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-bigquery</artifactId>
<version>1.102.0</version>
<version>1.106.0</version>
Copy link
Contributor

@elharo elharo Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely the upgrade that's causing the issues. I'd try splitting this out into a separate PR to isolate it.

@@ -108,6 +110,16 @@
<artifactId>grpc-google-cloud-bigquerystorage-v1beta2</artifactId>
<version>0.85.2-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-bigquerystorage-v1beta2:current} -->
</dependency>
<dependency>
Copy link
Contributor

@elharo elharo Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to add these two. Just move avro to the end of your dependencies section.

Copy link
Member Author

@stephaniewang526 stephaniewang526 Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Copy link
Contributor

@elharo elharo Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe not. The avro dependency on jackson is not as deep.

elharo
elharo approved these changes Feb 3, 2020
@stephaniewang526 stephaniewang526 merged commit b6418b4 into googleapis:master Feb 3, 2020
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants