Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v1 client generation #64

Merged
merged 1 commit into from Feb 6, 2020

Conversation

stephaniewang526
Copy link
Member

@stephaniewang526 stephaniewang526 commented Feb 6, 2020

Fixes b/147355958

@googlebot googlebot added the cla: yes label Feb 6, 2020
@stephaniewang526 stephaniewang526 requested a review from chingor13 Feb 6, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 6, 2020

Codecov Report

Merging #64 into master will increase coverage by 0.98%.
The diff coverage is 71.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
+ Coverage     70.16%   71.15%   +0.98%     
- Complexity      184      232      +48     
============================================
  Files            28       34       +6     
  Lines          1314     1643     +329     
  Branches          3        4       +1     
============================================
+ Hits            922     1169     +247     
- Misses          389      470      +81     
- Partials          3        4       +1
Impacted Files Coverage Δ Complexity Δ
.../bigquery/storage/v1/BaseBigQueryReadSettings.java 21.21% <21.21%> (ø) 2 <2> (?)
...oud/bigquery/storage/v1/stub/BigQueryReadStub.java 25% <25%> (ø) 1 <1> (?)
...orage/v1/stub/GrpcBigQueryReadCallableFactory.java 37.5% <37.5%> (ø) 3 <3> (?)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 50% <50%> (ø) 8 <8> (?)
...uery/storage/v1/stub/BigQueryReadStubSettings.java 84.67% <84.67%> (ø) 12 <12> (?)
...bigquery/storage/v1/stub/GrpcBigQueryReadStub.java 85.54% <85.54%> (ø) 9 <9> (?)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac340c...24ce076. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 902156d into googleapis:master Feb 6, 2020
14 checks passed
@stephaniewang526 stephaniewang526 added the release-please:force-run label Feb 6, 2020
@release-please release-please bot removed the release-please:force-run label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants