Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an enhanced layer for BigQuery Storage v1 client #66

Merged
merged 2 commits into from Feb 7, 2020

Conversation

mmladenovski
Copy link
Contributor

@mmladenovski mmladenovski commented Feb 6, 2020

This pull request creates an enhanced shim layer in the BigQuery Storage API v1 client in order to apply a streaming resumption strategy for the ReadRows method.

  • First commit copies the enhanced shim layer from v1beta2, since v1 and v1beta2 APIs are identical.
    • The files in this commit are just a copy, with no changes, from v1beta2. The commit exists just to make it easier to review the actual changes that are in the second commit.
  • Second commit just updates the version of the files from the v1 enhanced shim layer

@kmjung , please review the changes.

mmladenovski added 2 commits Feb 6, 2020
This commit makes it easier for reviewing later changes that update the enhanced layer to v1.
v1beta2 and v1 APIs are the same, with the only difference in the version.
@googlebot googlebot added the cla: yes label Feb 6, 2020
@kmjung
Copy link
Contributor

@kmjung kmjung commented Feb 6, 2020

LGTM.

@stephaniewang526 stephaniewang526 added the kokoro:force-run label Feb 7, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Feb 7, 2020
@codecov
Copy link

@codecov codecov bot commented Feb 7, 2020

Codecov Report

No coverage uploaded for pull request base (master@902156d). Click here to learn what that means.
The diff coverage is 65.06%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   70.81%           
  Complexity        ?      265           
=========================================
  Files             ?       39           
  Lines             ?     1809           
  Branches          ?        4           
=========================================
  Hits              ?     1281           
  Misses            ?      524           
  Partials          ?        4
Impacted Files Coverage Δ Complexity Δ
...e/v1/stub/readrows/ReadRowsResumptionStrategy.java 100% <100%> (ø) 5 <5> (?)
...loud/bigquery/storage/v1/BigQueryReadSettings.java 23.52% <23.52%> (ø) 3 <3> (?)
.../cloud/bigquery/storage/v1/BigQueryReadClient.java 52.94% <52.94%> (ø) 9 <9> (?)
...rage/v1/stub/EnhancedBigQueryReadStubSettings.java 81.25% <81.25%> (ø) 8 <8> (?)
...uery/storage/v1/stub/EnhancedBigQueryReadStub.java 82.92% <82.92%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902156d...1308cae. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 43fc284 into googleapis:master Feb 7, 2020
14 checks passed
@mmladenovski mmladenovski deleted the readapi_v1 branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants