Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A test race in JsonStreamWriterTest #722

merged 3 commits into from Dec 10, 2020


Copy link

@yirutang yirutang commented Dec 10, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Dec 10, 2020
@yirutang yirutang requested a review from tswast Dec 10, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage label Dec 10, 2020
@google-cla google-cla bot added the cla: yes label Dec 10, 2020
Copy link

@codecov codecov bot commented Dec 10, 2020

Codecov Report

Merging #722 (1fee452) into master (d90977f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #722   +/-   ##
  Coverage     80.40%   80.40%           
  Complexity      957      957           
  Files            73       73           
  Lines          5334     5334           
  Branches        405      405           
  Hits           4289     4289           
  Misses          877      877           
  Partials        168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d90977f...1fee452. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 35fe606 into googleapis:master Dec 10, 2020
19 checks passed
@yirutang yirutang deleted the fix-race-test branch Dec 10, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 14, 2020
🤖 I have created a release \*beep\* \*boop\* 
### [1.7.1]( (2020-12-14)

### Bug Fixes

* a build break caused by breaking change. ([#729]( ([a1b1c8e](
* A test race in JsonStreamWriterTest  ([#722]( ([35fe606](
* Add special type tests for Json writer and fix some type mapping issues ([#725]( ([ab6213c](
* Temporally disable test/code where breaking change is used to help pushing out the breaking change in unreleased Beta ([#727]( ([38c95c2](

### Dependencies

* update dependency to v0.16.1 ([d70bc3e](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: bigquerystorage cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants