-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add special type tests for Json writer and fix some type mapping issues #725
Conversation
JSONObject testStr = new JSONObject(); | ||
testStr.put("test_str", "aaa"); | ||
JSONObject testNumerics = new JSONObject(); | ||
testNumerics.put("test_numerics", new JSONArray(new String[]{"123.4", "-9000000"})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testNumerics.put("test_numerics", new JSONArray(new String[]{"123.4", "-9000000"})); | |
testNumerics.put("test_numerics", new JSONArray(new String[] {"123.4", "-9000000"})); |
Some unit tests are failing -- they need to be updated:
You could run |
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
=========================================
Coverage 80.40% 80.40%
Complexity 957 957
=========================================
Files 73 73
Lines 5334 5334
Branches 405 405
=========================================
Hits 4289 4289
Misses 877 877
Partials 168 168
Continue to review full report at Codecov.
|
🤖 I have created a release \*beep\* \*boop\* --- ### [1.7.1](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.7.0...v1.7.1) (2020-12-14) ### Bug Fixes * a build break caused by breaking change. ([#729](https://www.github.com/googleapis/java-bigquerystorage/issues/729)) ([a1b1c8e](https://www.github.com/googleapis/java-bigquerystorage/commit/a1b1c8edce87a8d33faf1067f617e3f47c4afc45)) * A test race in JsonStreamWriterTest ([#722](https://www.github.com/googleapis/java-bigquerystorage/issues/722)) ([35fe606](https://www.github.com/googleapis/java-bigquerystorage/commit/35fe606e43a47dfe844666bf3e385f9c2e582977)) * Add special type tests for Json writer and fix some type mapping issues ([#725](https://www.github.com/googleapis/java-bigquerystorage/issues/725)) ([ab6213c](https://www.github.com/googleapis/java-bigquerystorage/commit/ab6213c244162c74242d3aaf543bfcf9b2eb4405)) * Temporally disable test/code where breaking change is used to help pushing out the breaking change in unreleased Beta ([#727](https://www.github.com/googleapis/java-bigquerystorage/issues/727)) ([38c95c2](https://www.github.com/googleapis/java-bigquerystorage/commit/38c95c23459eb9c4a7215b1a3cb5243165f79815)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.16.1 ([d70bc3e](https://www.github.com/googleapis/java-bigquerystorage/commit/d70bc3e211ec579129ba53679572b49187f6b6e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️