fix: Disable Breaking change related code site #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquerystorage
google-cla
bot
added
the
cla: yes
| @@ -256,8 +256,11 @@ public void testJsonStreamWriterBatchWriteWithCommittedStream() | |||
| JSONArray row = new JSONArray(new JSONObject[] {testStr, testNumerics, testDateTime}); | |||
|
|
|||
| ApiFuture<AppendRowsResponse> response = | |||
| jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false); | |||
| assertEquals(0, response.get().getOffset()); | |||
| jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false); | |||
There was a problem hiding this comment.
Suggested change
| jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false); | |
| jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false); |
stephaniewang526
approved these changes
Dec 14, 2020
| @@ -257,6 +257,7 @@ public void testJsonStreamWriterBatchWriteWithCommittedStream() | |||
|
|
|||
| ApiFuture<AppendRowsResponse> response = | |||
| jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false); | |||
|
|
|||
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=========================================
Coverage 80.25% 80.25%
Complexity 957 957
=========================================
Files 73 73
Lines 5324 5319 -5
Branches 403 401 -2
=========================================
- Hits 4273 4269 -4
Misses 880 880
+ Partials 171 170 -1
Continue to review full report at Codecov.
|
yirutang
changed the title
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.7.2](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.7.1...v1.7.2) (2020-12-15) ### Bug Fixes * Disable Breaking change related code site ([#731](https://www.github.com/googleapis/java-bigquerystorage/issues/731)) ([d180293](https://www.github.com/googleapis/java-bigquerystorage/commit/d180293b47484c6257ae065f7ea2a5a6be8a5383)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.17.0 ([#735](https://www.github.com/googleapis/java-bigquerystorage/issues/735)) ([131d7a7](https://www.github.com/googleapis/java-bigquerystorage/commit/131d7a7626adebf9a0c97ffb2b0183a55086b5f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
shubhwip
pushed a commit
to shubhwip/java-bigquerystorage
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️