Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable Breaking change related code site #731

Merged
merged 17 commits into from Dec 15, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Dec 14, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Dec 14, 2020
@yirutang yirutang requested a review from tswast Dec 14, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage label Dec 14, 2020
@google-cla google-cla bot added the cla: yes label Dec 14, 2020
@@ -256,8 +256,11 @@ public void testJsonStreamWriterBatchWriteWithCommittedStream()
JSONArray row = new JSONArray(new JSONObject[] {testStr, testNumerics, testDateTime});

ApiFuture<AppendRowsResponse> response =
jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false);
assertEquals(0, response.get().getOffset());
jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false);
Copy link
Contributor

@yoshi-code-bot yoshi-code-bot Dec 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false);
jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false);

@@ -257,6 +257,7 @@ public void testJsonStreamWriterBatchWriteWithCommittedStream()

ApiFuture<AppendRowsResponse> response =
jsonStreamWriter.append(row, -1, /* allowUnknownFields */ false);

Copy link
Contributor

@yoshi-code-bot yoshi-code-bot Dec 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@codecov
Copy link

@codecov codecov bot commented Dec 14, 2020

Codecov Report

Merging #731 (d3518aa) into master (a1b1c8e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #731   +/-   ##
=========================================
  Coverage     80.25%   80.25%           
  Complexity      957      957           
=========================================
  Files            73       73           
  Lines          5324     5319    -5     
  Branches        403      401    -2     
=========================================
- Hits           4273     4269    -4     
  Misses          880      880           
+ Partials        171      170    -1     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 83.78% <ø> (+0.04%) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b1c8e...d3518aa. Read the comment docs.

@yirutang yirutang changed the title fix: Disable Breaking change related code site. fix: Disable Breaking change related code site Dec 15, 2020
@stephaniewang526 stephaniewang526 merged commit d180293 into googleapis:master Dec 15, 2020
17 of 19 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 15, 2020
@yirutang yirutang deleted the breaking-change branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants