Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tests that are disabled due to breaking change and stop ignoring ALREADY_EXISTED error #748

Merged
merged 14 commits into from Dec 21, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Dec 18, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Dec 18, 2020
@yirutang yirutang requested a review from pmakani Dec 18, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage label Dec 18, 2020
@google-cla google-cla bot added the cla: yes label Dec 18, 2020
@yirutang yirutang changed the title fix: enable tests that are disabled due to breaking change fix: enable tests that are disabled due to breaking change and stop ignoring ALREADY_EXISTED error Dec 18, 2020
@codecov
Copy link

@codecov codecov bot commented Dec 18, 2020

Codecov Report

Merging #748 (1ec0d35) into master (248ab73) will increase coverage by 0.08%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #748      +/-   ##
============================================
+ Coverage     80.72%   80.80%   +0.08%     
  Complexity      985      985              
============================================
  Files            73       73              
  Lines          5271     5289      +18     
  Branches        402      406       +4     
============================================
+ Hits           4255     4274      +19     
+ Misses          847      845       -2     
- Partials        169      170       +1     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 85.08% <91.66%> (+0.84%) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248ab73...1ec0d35. Read the comment docs.

@stephaniewang526 stephaniewang526 added the automerge label Dec 21, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8caf5a2 into googleapis:master Dec 21, 2020
19 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Dec 21, 2020
@yirutang yirutang deleted the enable-test branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants